The Toolstate System - Rust Forge (original) (raw)

Rust Forge

The Rust repository contains several external git submodules (e.g. the Book, the Reference). The toolstate system is used to allow these submodules to be in a broken state, except for beta releases.

This is necessary because the documentation is tested both on therust-lang/rust CI, and on the CI of the documentation repo. If there is a change to rustc that breaks the documentation, it would not be possible to update the documentation since the not-yet-merged version of rustc that breaks it doesn’t exist, yet. We usually require CI to be in a passing state in both repos.

The toolstate system solves this problem by temporarily allowing the documentation to be in a “failing” state on rust-lang/rust. When the tests start failing, the maintainers of the submodule will be notified. They will then be responsible for getting it fixed.

The three possible states of a “tool” are: test-pass, test-fail,build-fail.

This page gives a rough overview how the toolstate system works, and what the rules are for when which tools are (not) allowed to break.

Note: Historically, the toolstate system was used for managing tools that were closely coupled with the compiler (like rustfmt or miri). However, those have since been transitioned to use git subtrees instead, so that those tools must always pass their tests, and any failures must be resolved within the PR that breaks them.

This document uses the term “tool”, but as of this writing, the only thing tracked is external documentation.

• For all tools, if a PR changes that tool (if it changes the commit used by the submodule), the tool has to be in test-pass after this PR or else CI will fail.
• For all tools except for “nightly only” tools, the following extra rules are applied:
  • If a PR lands on the beta or stable branch, the tool has to be test-pass.
  • If a PR lands on master in the week before the beta is cut, and that PR regresses the tool (if it makes the state “worse”), CI fails. This is to help make sure all these tools become test-pass so that a beta can be cut. (See the Forge index for when the next beta cutoff is happening.)
    At the time of writing, the following tools are “nightly only”: embedded-book.

Updating the toolstate repository happens in two steps: when CI runs on the auto branch (where bors moves a PR to test if it is good for integration), the “tool” runners for the individual platforms (at the time of writing, Linux and Windows) each submit a JSON file to the repository recording the state of each tool for the commit they are testing. Later, if that commit actually entirely passed CI and bors moves it to the master branch, the “current tool status” in the toolstate repository is updated appropriately.

These scripts also automatically ping some people and create issues when tools break.

For further details, see the comments in the involved files: checktools.sh,publish_toolstate.py as well as the other files mentioned there.

Tools can be updated by updating the submodule to the proper commit.

Run git submodule update --remote path/to/submodule, add the updates, make sure the tests pass, commit, and send a pull request. The path is from the root of the rust repository, so for example, the reference issrc/doc/reference.

While not required, subup may assist you with this.

NOTE: We are trying to switch away from submodules and toolstate over time. Consider adding a subtree instead of a submodule: #70651

To add a new tool to be tracked, the following steps must be taken:

1. Create a PR to rust-lang/rust that adds the submodule along with any necessary build system / bootstrap updates. Be careful that the tests properly support ./x.py --no-fail-fast to avoidissues like this.
2. Include changes to checktools.sh:
   • Build the tool at the top. This is the step that actually generates the JSON status for the tool. When save-toolstates is set inconfig.toml, the rust build system will write a JSON file with the status of each test.
   • Add the tool to status_check with whether it should be a beta blocker or not.
3. Update publish_toolstate.py to add the tool. This includes a list of people to ping if the tool is broken, and its source repo. (Note: At the time of this writing, these users must have permissions to be assignable on rust-lang/rust GitHub.)
4. Submit a PR to the toolstate repository to manually add the tool to thelatest.json file.