15488 – possibly insufficient file permissions for executing test suite (original) (raw)

Since testsuite/lib/libstdc++.exp just copies over $srcdir/data/*.t[sx]t (which in TCL appearantly implies copying permissions [but not owner/group]), the files may all end up non-writable if the source tree was set so. I'd suggest

--- /usr/local/src/gcc-3.4.0/libstdc++-v3/testsuite/lib/libstdc++.exp 2004-03-18 18:38:09.000000000 +0100 +++ 3.4.0/libstdc++-v3/testsuite/lib/libstdc++.exp 2004-05-14 13:42:44.000000000 +0200 @@ -71,6 +71,8 @@ file copy -force dirname/dirname/dirname/symlink $dstdir } }

```
   set basename [file tail $f]
```

   file attributes <span class="katex"><span class="katex-mathml"><math xmlns="http://www.w3.org/1998/Math/MathML"><semantics><mrow><mi>d</mi><mi>s</mi><mi>t</mi><mi>d</mi><mi>i</mi><mi>r</mi><mi mathvariant="normal">/</mi></mrow><annotation encoding="application/x-tex">dstdir/</annotation></semantics></math></span><span class="katex-html" aria-hidden="true"><span class="base"><span class="strut" style="height:1em;vertical-align:-0.25em;"></span><span class="mord mathnormal">d</span><span class="mord mathnormal">s</span><span class="mord mathnormal">t</span><span class="mord mathnormal">d</span><span class="mord mathnormal">i</span><span class="mord mathnormal" style="margin-right:0.02778em;">r</span><span class="mord">/</span></span></span></span>basename -permissions a+w

} }

Comment 1 Benjamin Kosnik 2004-05-18 01🔞44 UTC

Same with this. Send it in as a patch: it looks like it may indeed be a bug, depending on how the originating sources are assigned permissions.

-benjamin

Comment 4 Drea Pinski 2004-05-19 23:51:05 UTC

Fixed.

Comment 5 jbeulich 2004-07-12 12:35:59 UTC

This isn't really fixed. The change to use remote_download in v3-copy-files made this patch unnecessary, and the way it was applied it actually became counter-productive since other than the submitted patch the one applied changes the mode of the source files (in the source tree, that is) rather than that of the destination files. If the user running the testsuite doesn't have sufficient rights to do so, the whole testsuite run now fails. In the light of all that, the patch simply needs to be backed out in both mainline and 3_4-branch.

Comment 9 Benjamin Kosnik 2004-07-20 00:16:13 UTC

Can I close this?

Comment 10 jbeulich 2004-07-20 08:52:12 UTC

I believe so.

Comment 11 Drea Pinski 2004-07-20 14:43:40 UTC

So closing as fixed.