Create check-dist.yml by brcrista · Pull Request #604 · actions/cache (original) (raw)

Conversation

@brcrista

This adds a workflow to check the contents of the checked-in dist/index.js against the expected version.

See actions/upload-artifact#227 for background and rationale.

@brcrista

@brcrista

konradpabjan

@konradpabjan

Forgot, but certain first party actions have pre and post steps so there are 2 index.js files

This will need some tweaks to take into account dist/restore/index.js and dist/save/index.js

@brcrista

@brcrista

@dhadka

Just FYI, we already do something like this -

- name: Ensure dist/ folder is up-to-date

, though I'm fine switching over so we have a consistent check for both actions.

@brcrista

Whoops, sorry @dhadka I didn't see your comment before I merged. I'm adding the same(-ish) workflow for all actions (see https://github.com/github/c2c-actions-service/issues/2382).

I actually think the existing implementation is a bit cleaner -- didn't occur to me that you don't have to mv the file before calling git diff. I think it makes sense as its own workflow, though. I'll make a follow-up PR.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})