docs: Indicate that restore-keys uses prefix in README by ELHoussineT · Pull Request #931 · actions/cache (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vsvipul

merged 3 commits into

Oct 3, 2022

Conversation

@ELHoussineT

I think we should state here that restore-keys supports prefixes as it is mentioned here.

@ELHoussineT

@ELHoussineT ELHoussineT changed the titleIndicate that restore-keys uses prefix in README docs: Indicate that restore-keys uses prefix in README

Sep 22, 2022

@vsvipul

I'm not sure if this is required. The line An ordered list of keys to use for restoring stale cache if no cache hit occurred for key already signifies what you are trying to add.

@ELHoussineT

@vsvipul "list of keys" does not disclose that the keys can be prefixes to the keys.

@vsvipul

@ELHoussineT Yes, I agree. In that case can we change that line itself to indicate that restore-keys are prefix matched?

@vsvipul

Something like An ordered list of prefix-matched keys to use for restoring stale cache if no cache hit occurred for key

@ELHoussineT

@ELHoussineT

@ELHoussineT

vsvipul

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vsvipul

Thank you for contributing 🎉

This was referenced

Oct 4, 2022

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

2 participants

@ELHoussineT @vsvipul