Consuming 3.0 actions/cache by tiwarishub · Pull Request #834 · actions/cache (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tiwarishub

We recently published actions/cache 3.0, which suppresses all the errors related caching except validation one. In this PR we are consuming that package to that error handling can be moved cache package.

vsvipul

const cacheId = await cache.saveCache(cachePaths, primaryKey, {
uploadChunkSize: utils.getInputAsInt(Inputs.UploadChunkSize)
});
if (cacheId == -1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do -

if (cacheId != -1) {
    core.info(`Cache saved with key: ${primaryKey}`);
}

vsvipul

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced

Oct 4, 2022

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

2 participants

@tiwarishub @vsvipul