[MENFORCER-422] Added externalRules rule by gastaldi · Pull Request #180 · apache/maven-enforcer (original) (raw)
Following this checklist to help us incorporate your
contribution quickly and easily:
- Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes. - Each commit in the pull request should have a meaningful subject line and body.
- Format the pull request title like
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
where you replaceMENFORCER-XXXwith the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message. - Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- Run
mvn clean verifyto make sure basic checks pass. A more thorough check will
be performed on your pull request automatically. - You have run the integration tests successfully (
mvn -Prun-its clean verify).
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
- I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
- In any other case, please file an Apache Individual Contributor License Agreement.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be great, thanks @gastaldi! Some comments inline.
Another important feature for the future: be able to customize the descriptor before processing, ideally through an XSLT. Motivation: some artifacts that are banned in Quarkus might be required in Camel Quarkus. With XSLT I could remove those specific ones from Quarkus descriptor and keep the rest.
Another important feature for the future: be able to customize the descriptor before processing, ideally through an XSLT. Motivation: some artifacts that are banned in Quarkus might be required in Camel Quarkus. With XSLT I could remove those specific ones from Quarkus descriptor and keep the rest.
@ppalaga because other transformation steps might be needed and because I wanted to keep it simple, I think this would be better served if the transformed file were already available as a separate dependency (eg. you could use the Maven dependency plugin to unpack the original rule XML, transform and include the transformed file in another dependency with another GAV), but we can discuss about that.
you could use the Maven dependency plugin to unpack the original rule XML, transform and include the transformed file in another dependency with another GAV), but we can discuss about that.
Yes, I know, but it is a sh** lot of XML that I hoped to be able to avoid :)
[MENFORCER-422] Added descriptors rule [MENFORCER-422] Added externalRules rule
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great!
I made one JavaDoc suggestion inline.
Otherwise, I wonder whether there is any Enforcer end user docs, where an externalRules example could be added?
Otherwise, I wonder whether there is any Enforcer end user docs, where an
externalRulesexample could be added?
I added an example doc in the generated site
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to quarkusio/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gastaldi, some small docs suggestions inline.
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks a lot, @gastaldi !
Would you like to review, @michael-o ? Otherwise, I could merge.
Co-authored-by: Peter Palaga ppalaga@redhat.com
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond those I have no objections. I will leave the merge to your judgement.
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
@michael-o do you happen to know whether an Enforcer release is planned already? Not sure where to look for that kind of info, although I am a committer.
@michael-o do you happen to know whether an Enforcer release is planned already? Not sure where to look for that kind of info, although I am a committer.
We don't publish any plans since we are volunteers.
First of all, please complete the accompanying JIRA issue. Second, someone needs to tackle https://issues.apache.org/jira/browse/MENFORCER-407 then we can consider a release.
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
gastaldi added a commit to gastaldi/quarkus that referenced this pull request
fercomunello pushed a commit to fercomunello/quarkus that referenced this pull request
evanchooly pushed a commit to nenros/quarkus that referenced this pull request
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})