[MPLUGIN-427] Expose generics information of parameter types in report by kwin · Pull Request #159 · apache/maven-plugin-tools (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

kwin

merged 3 commits into

Oct 26, 2022

Conversation

@kwin

@kwin

slawekjaranowski

@kwin

slawekjaranowski

@kwin

@kwin kwin deleted the feature/expose-generics-info-on-collections branch

October 26, 2022 13:59

@slawekjaranowski

@kwin

One issue what I see: in target/classes/META-INF/maven/plugin.xml is:

  <mojos>
    <mojo>
        <parameter>
          <name>reactorProjects</name>
          <type>java.util.List</type>
          <required>true</required>
          <editable>false</editable>
          <description></description>
        </parameter>
....

      <configuration>
     ...
     <reactorProjects implementation="java.util.List&lt;org.apache.maven.project.MavenProject&gt;" default-value="${reactorProjects}"/>
   ...
      </configuration>
...

should we have parameter type in configuration

@kwin

@gnodet Good catch, will make sure to emit the simple type there as well. A bit scary that there is no IT catching this...

Update: Tackled in #163.

@jira-importer

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})