[MPLUGIN-376] Drop legacy dependencies by cstamas · Pull Request #42 · apache/maven-plugin-tools (original) (raw)

Plugin used a lot of legacy code, misused Mojo test case
and used old Junit 3.x TestCase, and missed some
dependencies (junit mostly).

Changes:

• drop use of Junit 3 TestCase, use Junit4 everywhere
• fix misuses of AbstractMojoTestCase when it is NOT mojo being tested
• add missing junit test dep where missing
• drop legacy p-c-d, sisu using exclusions/replacements
• align JavaMojoDescriptorExtractorTest.java for semantic difference: current Shim returns empty list instead of null when no components (for null safety). Assers updated but semantic is same: "there are no components discovered".

Project cleaned up locally with help of apache/maven-parent#33
(locally modified parent and bashed POMs as long there were enforcer failures).

This PR continues work done in #37 and will be merged AFTER IT.