Weed out ITs by cstamas · Pull Request #45 · apache/maven-plugin-tools (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

apache / maven-plugin-tools Public

Additional navigation options

Merged

cstamas

merged 1 commit into

masterfrom

weed-out-its

Oct 19, 2021

ConversationCommits (1)ChecksFiles changed

Merged

Weed out ITs#45

cstamas

merged 1 commit into

masterfrom

weed-out-its

Conversation

@cstamas

@cstamas cstamas commented

Oct 18, 2021

Copy link Copy Markdown

Member

maven-plugin-api 2.0? Really?

@cstamas

`[Weed out ITs](/apache/maven-plugin-tools/pull/45/commits/e29e8519f6f644043331a22f90cd90e629cc8e05 "Weed out ITs

maven-plugin-api 2.0? Really?") `

[e29e851](/apache/maven-plugin-tools/pull/45/commits/e29e8519f6f644043331a22f90cd90e629cc8e05)

maven-plugin-api 2.0? Really?

@cstamas cstamas requested review fromgnodet and michael-o

October 18, 2021 08:14

@cstamas cstamas self-assigned this

Oct 18, 2021

@michael-o

michael-o commented

Oct 18, 2021

Copy link Copy Markdown

Member

maven-plugin-api 2.0? Really?

Because we can!

gnodet

gnodet approved these changes Oct 19, 2021

View reviewed changes

@gnodet gnodet left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, ITs are passing.

@cstamas cstamas merged commit 960d150 into master

Oct 19, 2021

@cstamas cstamas deleted the weed-out-its branch

October 19, 2021 07:49

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gnodet gnodet gnodet approved these changes

@michael-o michael-o Awaiting requested review from michael-o

Assignees

@cstamas cstamas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cstamas @michael-o @gnodet