[MPMD-353] - API incompatibility with jansi after upgrading m-shared-… by adangel · Pull Request #91 · apache/maven-pmd-plugin (original) (raw)

…utils

The call to MessageUtils.setColorEnabled() is not needed. Log output
from PMD is correctly colored depending on the maven settings.
No special handling is needed.

https://issues.apache.org/jira/browse/MPMD-353

I tested this locally - the API incompatibility is now gone for maven version 3.5.3 and 3.6.3. With this change, the plugin works now out of the box again with all maven version since 3.3.9 (didn't test older versions).

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MPMD-XXX] - Subject of the JIRA Ticket,
  where you replace MPMD-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.