Upgrade to maven 3.x and avoid using deprecated API by gnodet · Pull Request #4 · apache/maven-remote-resources-plugin (original) (raw)

Ground work for https://issues.apache.org/jira/browse/MNG-7266.

Upgrading to maven 3.1.1 is not really possible as the ProjectArtifactFactory has been introduced in 3.2.x branch and is required in order to get rid of the deprecated MavenProject.createArtifacts(xxx) method.

The ModelInheritanceAssembler and ModelUtils have been imported from maven-compat in order to not depend on that deprecated jar.

Personally I see this as a proof that our baseline of 3.1.1 is simply wrong/broken idea.

I am +1 on this change, but we should reconcile what is the proper baseline (I am in "the higher the better" ballpark). We should go 3.6 as baseline (and even then, we cover 3.6.x and 3.8.x that is still a huge time-span).

To me, 3.3.9 sounds like reasonable minimum for next year.

Personally I see this as a proof that our baseline of 3.1.1 is simply wrong/broken idea.

I am +1 on this change, but we should reconcile what is the proper baseline (I am in "the higher the better" ballpark). We should go 3.6 as baseline (and even then, we cover 3.6.x and 3.8.x that is still a huge time-span).

I don't have a strong opinion about forcing 3.6.x or 3.8.x, but I certainly think we should not forbid that. I'll merge the PR, we can always bump the maven version to a higher one if we want to align plugins.

Also, such a change deserves a JIRA ticket, including the message [MRRESOURCES-118] Require Maven 3.2.0.
I've created the ticket.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})