[SUREFIRE-2046] Resolved TODOs. Updated callbacks ForkedProcessPropertyEventListener and ForkedProcessStandardOutErrEventListener. by Tibor17 · Pull Request #501 · apache/maven-surefire (original) (raw)
The issue is SUREFIRE-1860 is a parent 6 child issues.
I forgot to update two listeners out of three which belong to handlers of test specifics.ForkedProcessReportEventListener was updated in SUREFIRE-2014 but the other two (ForkedProcessPropertyEventListener and ForkedProcessStandardOutErrEventListener) were missed.
Following this checklist to help us incorporate your
contribution quickly and easily:
- Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes. - Each commit in the pull request should have a meaningful subject line and body.
- Format the pull request title like
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
where you replaceSUREFIRE-XXXwith the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message. - Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- Run
mvn clean installto make sure basic checks pass. A more thorough check will
be performed on your pull request automatically. - You have run the integration tests successfully (
mvn -Prun-its clean install).
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
- I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
- In any other case, please file an Apache Individual Contributor License Agreement.