[SUREFIRE-2077] Allow consecutive spaces in argLine by mthmulders · Pull Request #527 · apache/maven-surefire (original) (raw)

The initial problem was with tabs in CLI. This was fixed in SUREFIRE-2063 but it was not a real fix because it was not a real bug. It was not a real bug, it was just an improvement because the CLI and the platform can see the tab as collision, in JPMS to be concrete, and hard to understand for most of the common users. Even Maarten did not understand the issue immediately and he found the cause finally. So we make these treatments in order to come over the user troubles.
We can argue in a loop and everybody may have a different opinion about these details on how to escape white space characters, and what characters should be considered as a replacement, etc.
I believe that having \t and maybe new line characters is the issue which origins in the POM itself and not in this code. So, if it is this place of the root cause then it should be fixed there as well. Maybe some warning would be helpful, and maybe enough, just my thoughts.