Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom by kwin · Pull Request #213 · codehaus-plexus/plexus-utils (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Conversation
Add test exposing that dominant blank (but non-empty) values are Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom
I wonder what will fail with current downstream consumer tests
I wonder what will fail with current downstream consumer tests
Any particular tests you have in mind? I will try to run Maven ITs against this change.
I wonder what will fail with current downstream consumer tests
Any particular tests you have in mind? I will try to run Maven ITs against this change.
Run this patched version against Core plugins ITs.
I'd like to run tests on plugins. Does it suffice to update Maven Core with this patch?
I modified Maven master to define<plexusUtilsVersion>3.4.3-SNAPSHOT</plexusUtilsVersion> in the reactor pom.xml, build it and ran the Maven Core integration tests successfully against that distro.
I modified Maven master to define
<plexusUtilsVersion>3.4.3-SNAPSHOT</plexusUtilsVersion>in the reactor pom.xml, build it and ran the Maven Core integration tests successfully against that distro.
Good, I will repeat with several core plugin ITs with 3.9.0-SNAPSHOT tomorrow.
Will this PR completely cover the downstream Maven issue?
Will this PR completely cover the downstream Maven issue?
No, it just allows to apply a workaround by giving a blank value in the plugin configuration to disable the default handling (FTR: the downstream issue is https://issues.apache.org/jira/browse/MNG-6434).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
