Improve alternate parsing by qmfrederik · Pull Request #596 · dotnet/Nerdbank.GitVersioning (original) (raw)
Conversation
There are at least two bugs in alternate parsing:
- On all platforms, the last value in the alternate files is ignored
- On Windows, the colon in full paths (e.g.
C:\Users\Me) is used as a separator
This PR attempts to fix both issues. Contributes towards #595
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple quick things to consider.
@qmfrederik If you push to this PR again, keep in mind I rebased your commits to allow for targeting the fix to v3.4. You should do a fetch and git reset --hard origin/features/alternates before doing more work to avoid inadvertently merging master into v3.4.
Co-authored-by: Andrew Arnott andrewarnott@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
