Added WAL compression checksum by cbi42 · Pull Request #10319 · facebook/rocksdb (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Closed
wants to merge 2 commits into
Closed
Added WAL compression checksum#10319
wants to merge 2 commits into
Conversation
Enabled zstd checksum flag in StreamingCompress so that WAL (de)compreression is protected by a checksum per compression frame.
Test plan:
make check- WAL perf: average ops/sec over 10 runs is 161226 pre PR and 159635 post PR (1% drop).
sudo TEST_TMPDIR=/dev/shm/memtable_write ./db_bench_checksum -benchmarks=fillseq -max_write_buffer_number=100 -num=1000000 -min_write_buffer_number_to_merge=10 -wal_compression=zstd
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
ajkr approved these changes Jul 11, 2022
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})