Fix wrong value passed in compaction filter in BlobDB by sherriiiliu · Pull Request #10391 · facebook/rocksdb (original) (raw)

Thanks so much for reporting and for the PR @sherriiiliu !

This issue is somewhat similar to what I'm addressing in #10490 w/r/t the DB iterator. I'm wondering if we could reset blob_value_ in e.g. CompactionIterator::Next() instead of here? It would have the same benefit as in the DB iterator, namely we would release any cache handles as soon as possible. (Also note that GC uses blob_value_ as well, so it might be non-empty for non-compaction filter related reasons.)