7.6 patch by gitbw95 · Pull Request #10564 · facebook/rocksdb (original) (raw)
and others added 2 commits
…lush() is involved (facebook#10555)
Summary: facebook#10489 adds an assertion in most functions in WritableFileWriter to check no previous error. However, it only works without calling SyncWithoutFlush(). The nature of SyncWithoutFlush() makes two concurrent call fails to check status code of each other and causing assertion failure. Fix the problem by skipping the check after SyncWithoutFlush() is called and not check status code in SyncWithoutFlush().
Since the original change was not officially released yet, the fix isn't added to HISTORY.md.
Pull Request resolved: facebook#10555
Test Plan: Make sure existing tests still pass
Reviewed By: anand1976
Differential Revision: D38946208
fbshipit-source-id: 63566732d3f25c8a8342840499cf7b7d745f27c2
Summary: see diff
Pull Request resolved: facebook#10557
Test Plan: no functional change
Reviewed By: gitbw95
Differential Revision: D38950531
Pulled By: pdillinger
fbshipit-source-id: af72e80a31d7df38f6e633fa7115984c2274ed60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})