Fix incorrect bitmask in Pointer#createConstant(int) by dbwiddis · Pull Request #1472 · java-native-access/jna (original) (raw)

Fixes #1470

Pointer#hashCode: defined the mask properly to show author intent, although one could just as easily add without masking because of the eventual downcast.

ProxyObject#hashCode: this one had an additional useless mask of a number already shifted right 32 bits and guaranteed to have 0's in the high bits. And in addition to the useless mask of the low bits it then gets downcast to int and then widened again for the addition. Simplified it to match the Pointer version.

Pointer#createConstant(int) states in its javadocs that it is supposed to avoid setting the high bits. However, with the improper masking it ends up setting all the high bits for any negative ints.