Added option to set a parent Observation on an existing Observation by marcingrzejszczak · Pull Request #3291 · micrometer-metrics/micrometer (original) (raw)

@marcingrzejszczak

without this change in order to e.g. create spans we always need to put an observation in scope so that spans are put in thread local and a child span is being set. That doesn't make a lot of sense when we exactly know what the parent observation is. with this change we're allowing to set a parent observation direcly on an existing observation. That way we're able to maintain a parent child relationship of observations and of e.g. spans

marcingrzejszczak added a commit to micrometer-metrics/tracing that referenced this pull request

Jul 14, 2022

@marcingrzejszczak

without this change in order to e.g. create spans we always need to put an observation in scope so that spans are put in thread local and a child span is being set. That doesn't make a lot of sense when we exactly know what the parent observation is. with this change we're allowing to set a parent observation direcly on an existing observation. That way we're able to maintain a parent child relationship of observations and of e.g. spans

related to micrometer-metrics/micrometer#3291

[sonatype-lift[bot]](/apps/sonatype-lift)

[sonatype-lift[bot]](/apps/sonatype-lift)

[sonatype-lift[bot]](/apps/sonatype-lift)

[sonatype-lift[bot]](/apps/sonatype-lift)

shakuzen

@marcingrzejszczak

@marcingrzejszczak

marcingrzejszczak added a commit to micrometer-metrics/tracing that referenced this pull request

Jul 15, 2022

@marcingrzejszczak

)

without this change in order to e.g. create spans we always need to put an observation in scope so that spans are put in thread local and a child span is being set. That doesn't make a lot of sense when we exactly know what the parent observation is. with this change we're allowing to set a parent observation direcly on an existing observation. That way we're able to maintain a parent child relationship of observations and of e.g. spans

related to micrometer-metrics/micrometer#3291

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})