Use all remote repositories for artifacts resolving by slawekjaranowski · Pull Request #226 · mojohaus/extra-enforcer-rules (original) (raw)

@slawekjaranowski

we should use default remote repositories and repositories defined in project

Fix #225

basil

MarkEWaite

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jglick

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

@basil

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

You must not trust me.

@slawekjaranowski

we should use default remote repositories and repositories defined in project

Fix #225

@MarkEWaite

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

I did not. I'm happy to attempt that verification if it helps. As far as I can tell, the duplication instructions in the issue report should be repeatable. They are:

$ rm -rf implied-labels-plugin $ git clone https://github.com/jenkinsci/implied-labels-plugin.git $ cd implied-labels-plugin $ echo '' > settings.xml $ mvn validate

@slawekjaranowski

I have tested my change with implied-labels-plugin project according to instructions from issue.

I override version for test in pom, like:

  <build>
    <plugins>
        <plugin>
          <artifactId>maven-enforcer-plugin</artifactId>
          <dependencies>
            <dependency>
              <groupId>org.codehaus.mojo</groupId>
              <artifactId>extra-enforcer-rules</artifactId>
              <version>1.6.1-SNAPSHOT</version>
            </dependency>
          </dependencies>
        </plugin>
      </plugins>
  </build>

@basil basil mentioned this pull request

Jul 24, 2022

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})