Document known quirks of EnumDescriptor::is_closed() when importing a… by zhangskz · Pull Request #11946 · protocolbuffers/protobuf (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

protocolbuffers / protobuf Public

Additional navigation options

Merged

zhangskz

merged 1 commit into

22.xfrom

cp-enum-closed-comment

Feb 15, 2023

ConversationCommits (1)ChecksFiles changed

Merged

Document known quirks of EnumDescriptor::is_closed() when importing a…#11946

zhangskz

merged 1 commit into

22.xfrom

cp-enum-closed-comment

Conversation

@zhangskz

@zhangskz zhangskz commented

Feb 14, 2023

Copy link Copy Markdown

Member

…cross files with different syntaxes.

PiperOrigin-RevId: 509581394

@protobuf-github-bot @zhangskz

`[Document known quirks of EnumDescriptor::is_closed() when importing a…](/protocolbuffers/protobuf/pull/11946/commits/a594141cc408b972c9ffe2bcf14958174d0a4fe4 "Document known quirks of EnumDescriptor::is_closed() when importing across files with different syntaxes.

PiperOrigin-RevId: 509581394") `

[a594141](/protocolbuffers/protobuf/pull/11946/commits/a594141cc408b972c9ffe2bcf14958174d0a4fe4)

…cross files with different syntaxes.

PiperOrigin-RevId: 509581394

@zhangskz zhangskz requested review fromdeannagarcia and mcy

February 14, 2023 22:05

deannagarcia

deannagarcia approved these changes Feb 14, 2023

View reviewed changes

@zhangskz zhangskz merged commit 8d7b4e6 into 22.x

Feb 15, 2023

@zhangskz zhangskz deleted the cp-enum-closed-comment branch

February 15, 2023 05:16

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mcy mcy Awaiting requested review from mcy

1 more reviewer

@deannagarcia deannagarcia deannagarcia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangskz @deannagarcia @protobuf-github-bot