Document known quirks of EnumDescriptor::is_closed() when importing a… by zhangskz · Pull Request #11946 · protocolbuffers/protobuf (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
protocolbuffers / protobuf Public
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 1 commit into
22.xfrom
Feb 15, 2023
ConversationCommits (1)ChecksFiles changed
Merged
Document known quirks of EnumDescriptor::is_closed() when importing a…#11946
merged 1 commit into
22.xfrom
Conversation
zhangskz commented
Copy link Copy Markdown
Member
…cross files with different syntaxes.
PiperOrigin-RevId: 509581394
`[Document known quirks of EnumDescriptor::is_closed() when importing a…](/protocolbuffers/protobuf/pull/11946/commits/a594141cc408b972c9ffe2bcf14958174d0a4fe4 "Document known quirks of EnumDescriptor::is_closed() when importing across files with different syntaxes.
PiperOrigin-RevId: 509581394") `
[a594141](/protocolbuffers/protobuf/pull/11946/commits/a594141cc408b972c9ffe2bcf14958174d0a4fe4)
…cross files with different syntaxes.
PiperOrigin-RevId: 509581394
zhangskz requested review fromdeannagarcia and mcy
deannagarcia approved these changes Feb 14, 2023
zhangskz merged commit 8d7b4e6 into 22.x
zhangskz deleted the cp-enum-closed-comment branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
mcy Awaiting requested review from mcy
1 more reviewer
deannagarcia deannagarcia approved these changes
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.