Fix crash with walrus + await + with by JelleZijlstra · Pull Request #3473 · psf/black (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub Copilot appDirect agents from issue to merge
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

psf / black Public

• Notifications You must be signed in to change notification settings

• Fork2.8k

• Star 41.6k

• Code

• Issues 270

• Pull requests 15

• Actions

• Projects

• Security and quality 2

• Insights

Additional navigation options

Merged

JelleZijlstra

merged 5 commits into

psf:mainfrom

JelleZijlstra:main

Jan 18, 2023

ConversationCommits (5)ChecksFiles changed

Merged

Fix crash with walrus + await + with#3473

JelleZijlstra

merged 5 commits into

psf:mainfrom

JelleZijlstra:main

Conversation

JelleZijlstra commented

Dec 25, 2022

Copy link Copy Markdown

Collaborator

Fixes #3472

`[Fix crash with walrus + await + with](/psf/black/pull/3473/commits/c31425e434a7e4f8b3e38ba344f940326787bd93 "Fix crash with walrus + await + with

Fixes #3472") `

[c31425e](/psf/black/pull/3473/commits/c31425e434a7e4f8b3e38ba344f940326787bd93)

Fixes psf#3472

github-actions Bot commented

Dec 25, 2022

•

edited

Loading

Copy link Copy Markdown

Contributor

diff-shades reports zero changes comparing this PR (cbcee44) to main (d4ff985).

What is this? | Workflow run | diff-shades documentation

JelleZijlstra added 3 commits

December 25, 2022 07:23

[Fix more crashes](/psf/black/pull/3473/commits/e27cc3a1d997024cbb659367e04d7778731377c9 "Fix more crashes")

[e27cc3a](/psf/black/pull/3473/commits/e27cc3a1d997024cbb659367e04d7778731377c9)

[format self](/psf/black/pull/3473/commits/c6e09d0b9329424acb71a97ca991f5266210d596 "format self")

[c6e09d0](/psf/black/pull/3473/commits/c6e09d0b9329424acb71a97ca991f5266210d596)

[add a few more cases](/psf/black/pull/3473/commits/46f7e55690a3f08fe95f8246d724df5ee6f9d21c "add a few more cases")

[46f7e55](/psf/black/pull/3473/commits/46f7e55690a3f08fe95f8246d724df5ee6f9d21c)

ichard26 requested changes Dec 27, 2022

View reviewed changes

ichard26 left a comment

Copy link Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd double check the test data file. I don't think it's testing what you want.

Comment thread

tests/data/py_38/pep_572_remove_parens.py

ichard26 approved these changes Jan 14, 2023

View reviewed changes

[Merge branch 'main' into main](/psf/black/pull/3473/commits/cbcee44dc2acece3ae00b516e3bb2ec76049f51b "Merge branch 'main' into main")

[cbcee44](/psf/black/pull/3473/commits/cbcee44dc2acece3ae00b516e3bb2ec76049f51b)

cooperlees approved these changes Jan 16, 2023

View reviewed changes

JelleZijlstra merged commit 7e6d3fa into psf:main

Jan 18, 2023

JelleZijlstra deleted the main branch

January 18, 2023 06:25

JelleZijlstra restored the main branch

January 18, 2023 06:25

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

cooperlees cooperlees approved these changes

ichard26 ichard26 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preview style: Crash on walrus in with statement

3 participants