Improve logging when connection closed after cancel by pderop · Pull Request #2585 · reactor/reactor-netty (original) (raw)
added 2 commits
…is registered to inbound receiver
1.0.x improve logging when connection closed after cancel Improve logging when connection closed after cancel
…http client when it is cancelled before the response is received from the server
… http server when it is cancelled before the request is fully consumed.
…m connection close.
The client from testTcpClientCancelled test will log "Channel inbound receiver cancelled (operation cancelled)". The server from testTcpServerCancelled test will log "Channel inbound receiver cancelled (operation cancelled)". The client from testTcpClientCancelledByServerClose test will log "Channel inbound receiver cancelled (channel disconnected)". The client from testUdpClientCancelled test will log "Channel inbound receiver cancelled (operation cancelled)" on cancellation while reading, and when the client is disposed, it will log "Channel inbound receiver cancelled (subscription disposed).". The testUdpServerCancelled test will log "Channel inbound receiver cancelled (operation cancelled) on cancellation while reading.
The client from testHttpClientCancelled test will log "Http client inbound receiver cancelled, closing channel" on cancellation while reading response. The server from testHttpClientCancelled test will log "[HttpServer] Channel inbound receiver cancelled (operation cancelled)." when the response has been sent (because the receiver is cancelled once the response is sent. The server from testHttpServerCancelled test will log "[HttpServer] Channel inbound receiver cancelled (operation cancelled)" when cancelled while reading request. The client from testHttpServerCancelled test will log "Http client inbound receiver cancelled, closing channel" when cancelled after having received the response from the server.
The client type must be BIDIRECTIONAL in order to avoid cancelling the receiver automatically.
This is necessary to let this class be ignored by the NativeConfigTest when we will merge into netty5 branch (the NativeConfigTest in netty5 branch ignores all *Test classes, and we don't want the CancelReceiverHandler to be parsed by the NativeConfigTest class).
This is needed in order to make sure the test will work in netty5, where socket close listeners are scheduled differently.
pderop added a commit that referenced this pull request
pderop added a commit that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})