xunit v3 preparation by martincostello · Pull Request #2723 · App-vNext/Polly (original) (raw)
Pull Request Overview
This PR prepares the codebase for xunit v3 by introducing a shared TestCancellation utility and standardizing test cancellation token usage across the entire test suite. The changes improve test consistency and prepare for potential future xunit compatibility requirements.
Key changes:
- Addition of
TestCancellation.Tokenhelper to centralize test cancellation token management - Systematic replacement of
CancellationToken.NonewithTestCancellation.Tokenin all test files - Addition of thread-safe semaphore release logic in production code to prevent ObjectDisposedException
Reviewed Changes
Copilot reviewed 128 out of 128 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Shared/TestCancellation.cs | New shared utility providing centralized test cancellation token |
| Multiple test project .csproj files | Added references to shared TestCancellation utility |
| 100+ test files | Replaced CancellationToken.None with TestCancellation.Token throughout |
| src/Polly/Bulkhead/BulkheadEngine.cs | Added safe semaphore release to prevent ObjectDisposedException |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.