Support package with SemVer2 version with buildMetadata by JoC0de · Pull Request #543 · GlitchEnzo/NuGetForUnity (original) (raw)
| /// Initializes a new instance of the struct. |
|---|
| /// |
| /// Dummy to allow calling this constructor. |
| public SemVer2Version(bool dummy) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a better option would be a static SemVer2Version Create() method?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never used struct in a old C# language version where there Default constructor is not supported.
I just didn't hat that in mind. If you like you can change it.
| /// |
|---|
| /// If true the is included. |
| /// The formatted string. |
| public string ToString(bool withBuildMetadata = false) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reporting a warning Method with optional parameter is hidden by overload. Is there a reason this parameter is optional?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No you can remove the = false. I need to install ReSharper 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})