Avoid unzipping .nupkg every time we need to read from .nuspec by saving .nuspec inside the package folder instead of .nupkg by popara96 · Pull Request #570 · GlitchEnzo/NuGetForUnity (original) (raw)
Backwards compatibility is managed by checking for .nupkg files and if there are some, we unpack .nuspec file from them and delete them. Tests have also been changed accordingly.
…d unzipping to read nuspec. Managed backwards compatibility and fixed tests
that may beclosed by this pull request
Hi,
The failing tests are the one that try to install a nuget package from a lokal package source. Most probably the issue is in the setup because it needs the .nupkg file from a previous install to create a lokal package source.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to rebase, and there is one missing conversation
After this gets approved, I will push the squashed commit directly to master.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@popara96 why directly pushing to master. I don't like when PRs are skipped as they ensure e.g. that the CI works. I would just squash the commits -> rebase -> merge PR. So we keep the link to the PR / it will be listed correctly inside the Release Nodes.
Does that mean we force push the branch after rebase + squash? We were not sure if we force push was allowed.
Does that mean we force push the branch after rebase + squash? We were not sure if we force push was allowed.
Yes force-push on branches is allowed (not on main), you can do --force-with-leas so the complete history still exists. At leas I do it, but I always create branches on my fork. Without force-push it would be also possible but then you need to do a merge commit (I also prefer rebase over merging)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})