Shortening the path of source files in source code nuget packages by popara96 · Pull Request #577 · GlitchEnzo/NuGetForUnity (original) (raw)
This PR will sort out long paths made by source code packages by unpacking all source files inside the packageDirectory/Sources.
that may beclosed by this pull request
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code 👍
It would be nice to at least have one NuGet package that has source code to be installed by the Test so we can ensure this woks / doesn't brake later.
We could even create a ZipFile on-the-fly just for testing instead of using a existing .nupkg
Will write tests tomorrow.
| [Test] |
|---|
| [TestCase("Microsoft.Azure.WebJobs.Sources", "3.0.37")] |
| [TestCase("NServiceBus.Testing.Fakes.Sources", "7.1.13")] |
| public void TestSourceCodePackageInstall(string packageId, string packageVersion) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a check to see if Sources directory is added in the package root and ensured that contentFiles directory doesn't exist. I'm trying to thing of other generic checks that we could do while installing this but nothing comes to mind as directories/files under Sources will be very package-specific. H
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any more issues, I would only fix the formatting at some places. See e.g. the Compiler warnings about trailing whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})