Implemented support for selecting multiple packages for installation by igor84 · Pull Request #611 · GlitchEnzo/NuGetForUnity (original) (raw)

@igor84

popara96

JoC0de

@JoC0de JoC0de left a comment • Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay
looks good to me 👍
only one small note (can be ignored)

EditorGUI.LabelField(rectangle, string.Empty, headerStyle);
var arrow = showPackagesToInstall ? "\u2227" : "\u2228";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have used some constants for the string so we don't have "magic numbers"

@igor84

…ect all from clipboard button

@igor84

I realized I didn't properly handle packages that are already installed or are available in Unity in the selection code so I fixed that. I also added a "Select all from clipboard" button so users can copy a list of package ids they need to install from somewhere and just click this button to have them all selected for installation.

@igor84

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})