#697 add capability to expend env variable in username by QuentinBrun · Pull Request #698 · GlitchEnzo/NuGetForUnity (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Merged
merged 2 commits into
Feb 15, 2025
Conversation
@QuentinBrun thanks for the contribution.
I am not sure if we can implement it in this easy way. The UserName property should be renamed to SavedUserName to be consistent with the SavedPassword property. But it affects the public interface INugetPackageSource witch impacts our plugin system.
@igor84 what is your opinion on this?
Our plugin system is still very young so I would be surprised if anyone beside me is using it :) and since I don't use username in my plugin and configuration it wouldn't really break anything... So I would be ok with changing it.
that may beclosed by this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})