fix: rule name patterns · GoogleCloudPlatform/prometheus-engine@6abd262 (original) (raw)
`@@ -867,10 +867,30 @@ func TestCRDValidation(t *testing.T) {
`
867
867
` })
`
868
868
`t.Run("Rules", func(t *testing.T) {
`
869
869
`tests := map[string]test{
`
870
``
`-
"minimal": {
`
``
870
`+
"minimal-alerting": {
`
871
871
`obj: &monitoringv1.Rules{
`
872
872
`ObjectMeta: metav1.ObjectMeta{
`
873
``
`-
Name: "minimal",
`
``
873
`+
Name: "minimal-alerting",
`
``
874
`+
Namespace: "default",
`
``
875
`+
},
`
``
876
`+
Spec: monitoringv1.RulesSpec{
`
``
877
`+
Groups: []monitoringv1.RuleGroup{
`
``
878
`+
{
`
``
879
`+
Rules: []monitoringv1.Rule{
`
``
880
`+
{
`
``
881
`+
Alert: "Any-characters:Allowed!?#@",
`
``
882
`+
},
`
``
883
`+
},
`
``
884
`+
},
`
``
885
`+
},
`
``
886
`+
},
`
``
887
`+
},
`
``
888
`+
wantErr: false,
`
``
889
`+
},
`
``
890
`+
"minimal-recording": {
`
``
891
`+
obj: &monitoringv1.Rules{
`
``
892
`+
ObjectMeta: metav1.ObjectMeta{
`
``
893
`+
Name: "minimal-recording",
`
874
894
`Namespace: "default",
`
875
895
` },
`
876
896
`Spec: monitoringv1.RulesSpec{
`
`@@ -928,6 +948,46 @@ func TestCRDValidation(t *testing.T) {
`
928
948
` },
`
929
949
`wantErr: true,
`
930
950
` },
`
``
951
`+
"invalid-rule-name-dash": {
`
``
952
`+
obj: &monitoringv1.Rules{
`
``
953
`+
ObjectMeta: metav1.ObjectMeta{
`
``
954
`+
Name: "invalid-rule-name-dash",
`
``
955
`+
Namespace: "default",
`
``
956
`+
},
`
``
957
`+
Spec: monitoringv1.RulesSpec{
`
``
958
`+
Groups: []monitoringv1.RuleGroup{
`
``
959
`+
{
`
``
960
`+
Rules: []monitoringv1.Rule{
`
``
961
`+
{
`
``
962
`+
Record: "dashes-not-allowed",
`
``
963
`+
},
`
``
964
`+
},
`
``
965
`+
},
`
``
966
`+
},
`
``
967
`+
},
`
``
968
`+
},
`
``
969
`+
wantErr: true,
`
``
970
`+
},
`
``
971
`+
"valid-rule-name-colon": {
`
``
972
`+
obj: &monitoringv1.Rules{
`
``
973
`+
ObjectMeta: metav1.ObjectMeta{
`
``
974
`+
Name: "valid-rule-name-colon",
`
``
975
`+
Namespace: "default",
`
``
976
`+
},
`
``
977
`+
Spec: monitoringv1.RulesSpec{
`
``
978
`+
Groups: []monitoringv1.RuleGroup{
`
``
979
`+
{
`
``
980
`+
Rules: []monitoringv1.Rule{
`
``
981
`+
{
`
``
982
`+
Record: "colon:allowed",
`
``
983
`+
},
`
``
984
`+
},
`
``
985
`+
},
`
``
986
`+
},
`
``
987
`+
},
`
``
988
`+
},
`
``
989
`+
wantErr: false,
`
``
990
`+
},
`
931
991
`"invalid-annotation": {
`
932
992
`obj: &monitoringv1.Rules{
`
933
993
`ObjectMeta: metav1.ObjectMeta{
`