Fix link to dynamic scope script in userinfo.md by ANEMBHARGAV · Pull Request #12519 · JanssenProject/jans (original) (raw)

@ANEMBHARGAV

Updated link for dynamic scope interception script.

Prepare


Description

Target issue

closes #12255

Implementation Details


Test and Document the changes

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

Summary by CodeRabbit

@ANEMBHARGAV

Updated link for dynamic scope interception script.

Signed-off-by: ANEM BHARGAV anembhargav02@gmail.com

@mo-auto

@coderabbitai

📝 Walkthrough

Walkthrough

A broken internal documentation link in the Userinfo Endpoint file was corrected to point to the proper script catalog location. The link path was updated from ../../developer/scripts/dynamic-scope.md to ../../../script-catalog/dynamic_scope/dynamic-scope.md, and proper newline formatting was restored at the end of the file.

Changes

Cohort / File(s) Summary
Documentation Link Fix docs/janssen-server/auth-server/endpoints/userinfo.md Updated broken internal link reference for dynamic scope documentation to correct path within script-catalog directory; restored proper newline at end of file

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (3 passed)

Check name Status Explanation
Title Check ✅ Passed The title "Fix link to dynamic scope script in userinfo.md" directly and clearly summarizes the primary change in this pull request. It's concise, specific, and immediately communicates that a link was fixed in a particular documentation file. The title accurately reflects what the raw summary shows: an updated link reference in the userinfo.md file from an old path to a new path, which is exactly what a teammate scanning the history needs to understand.
Linked Issues Check ✅ Passed The code changes precisely address the primary objective from linked issue #12255. The raw summary confirms that the link was updated from the exact broken path ../../developer/scripts/dynamic-scope.md to the proposed fix ../../../script-catalog/dynamic_scope/dynamic-scope.md, matching the requirement verbatim. This is the core coding requirement from the linked issue, and it has been successfully implemented in the userinfo.md file.
Out of Scope Changes Check ✅ Passed The changes in this pull request are well within scope. The primary change—updating the broken link to the dynamic scope script—directly addresses the objective in linked issue #12255. The secondary change of restoring proper newline handling at the end of the file is a standard file formatting fix that's typically performed alongside documentation edits and doesn't introduce any unrelated functionality. All changes support the stated objective.

✨ Finishing touches 🧪 Generate unit tests (beta)


Comment @coderabbitai help to get the list of available commands and usage tips.

[coderabbitai[bot]](/apps/coderabbitai)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc863c8 and 533d0ac.

📒 Files selected for processing (1)

[uncategorized] ~98-~98: Do not mix variants of the same word (‘customize’ and ‘customise’) within a single text.
Context: ... Response from userinfo can be further customized using [dynamic scope](../../../script-c...

(EN_WORD_COHERENCY)


[style] ~105-~105: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

🪛 markdownlint-cli2 (0.18.1) docs/janssen-server/auth-server/endpoints/userinfo.md

100-100: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

🔇 Additional comments (1)

docs/janssen-server/auth-server/endpoints/userinfo.md (1)

98-98: Link path verified and locked in—no 404s on this watch, my friend!

The target file exists at ./docs/script-catalog/dynamic_scope/dynamic-scope.md, confirming that the path update from ../../developer/scripts/dynamic-scope.md to ../../../script-catalog/dynamic_scope/dynamic-scope.md is correct and points to valid documentation. The fix aligns perfectly with issue #12255, and you've done solid work here!

ossdhaval

@ossdhaval

[coderabbitai[bot]](/apps/coderabbitai)

This was referenced

Nov 24, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})