fix(docs): fix linting issues - trailing spaces and EOF newline by ossdhaval · Pull Request #12731 · JanssenProject/jans (original) (raw)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38b81a3 and 00ed8b3.

📒 Files selected for processing (66) 

Learnt from: ossdhaval
Repo: JanssenProject/jans PR: 12539
File: docs/janssen-server/auth-server/client-management/software-statements.md:29-29
Timestamp: 2025-10-30T15:21:12.720Z
Learning: In the Janssen Project documentation (docs/ directory), relative links in markdown files work correctly when tested locally even when intermediate directory segments like "janssen-server" appear to be missing from the relative path. The documentation build system handles path resolution appropriately, so local testing by developers is authoritative for verifying link correctness.

Applied to files:

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12704
File: jans-config-api/docs/jans-config-api-swagger.yaml:17540-17546
Timestamp: 2025-11-18T07:43:55.761Z
Learning: The file `jans-config-api/docs/jans-config-api-swagger.yaml` is auto-generated with dependent modules changes and metadata. The config API does not override it.

Applied to files:

Learnt from: yuriyz
Repo: JanssenProject/jans PR: 12596
File: docs/janssen-server/auth-server/tokens/oauth-tx-tokens.md:146-257
Timestamp: 2025-11-19T12:55:01.596Z
Learning: In the Janssen project, the TxToken custom script documentation is intentionally duplicated in both `docs/janssen-server/auth-server/tokens/oauth-tx-tokens.md` and `docs/script-catalog/tx_token/txtoken.md` to provide easy access from both the transaction token documentation and the script catalog.

Applied to files:

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/api-access-control/client-credential-grant-flow.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/apps/drupal.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/other/wikid/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/forcing-reauthn.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/uma_rpt_policy/uma-rpt-policy/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/api-access-control/openapi-best-practice.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/apps/moodle.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/single-page-apps.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/passwordless.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

jans-auth-server/agama/README.md

[style] ~4-~4: ‘by means of’ might be wordy. Consider a shorter alternative.
Context: ...ication flows are defined in the server by means of jython scripts that adhere to a predefi...

(EN_WORDINESS_PREMIUM_BY_MEANS_OF)

[grammar] ~4-~4: Use a hyphen to join words.
Context: ... Agama, flows are coded in a DSL (domain specific language) designed for the sole...

(QB_NEW_EN_HYPHEN)

docs/janssen-server/recipes/api-access-control/scope-access.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/yubicloud-external-authenticator/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/api-access-control/user-claims-tokens.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/revoke_token/revoke-token.md

[style] ~125-~125: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/impersonation.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/other/idfirst/README.md

[uncategorized] ~37-~37: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...this script * Ensure this script has a low level set in oxTrust. All other scripts to wh...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

docs/janssen-server/recipes/apps/kafka.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/device-flow-config.md

[style] ~20-~20: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/introspection/introspection/README.md

[style] ~11-~11: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/inbound-saml.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/apps/magento.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/persistence_extension/persistence.md

[style] ~22-~22: In American English, abbreviations like “etc.” require a period.
Context: ...ntity (person, session, client, scripts etc) constitutes an Entry. The Entry Ma...

(ETC_PERIOD)

docs/script-catalog/person_authentication/agama-bridge/README.md

[style] ~11-~11: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/web-apps.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/introspection/introspection-custom-parameters/README.md

[style] ~11-~11: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/faq.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/adaptive-authn.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/uma_claims_gathering/uma-claims-web.md

[style] ~131-~131: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/uma_rpt_claims/uma-claims-jwt.md

[style] ~73-~73: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/README.md

[grammar] ~5-~5: Use a hyphen to join words.
Context: ...these scripts as well as additional (non curated) scripts that you may use as a g...

(QB_NEW_EN_HYPHEN)

[grammar] ~5-~5: Use a hyphen to join words.
Context: ...ou may use as a guide to integrate third party authentication services or APIs wi...

(QB_NEW_EN_HYPHEN)

docs/script-catalog/person_authentication/other/phonefactor/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/otp-external-authenticator/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/smpp-2fa/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/api-access-control/software-statements.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/introspection/introspection-role-based-scope/README.md

[style] ~11-~11: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/idp/idp-extension.md

[style] ~156-~156: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/spontaneous_scope/spontaneous-scope.md

[style] ~82-~82: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/registration.md

[style] ~19-~19: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/user-cert-external-authenticator/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/ssa/ssa-modify-response.md

[style] ~22-~22: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/script-catalog/person_authentication/other/toopher/README.md

[style] ~12-~12: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/password-expirations.md

[style] ~19-~19: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/casa/administration/faq.md

[style] ~66-~66: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...ice used (for instance, a mobile phone) with respect to server time should not be representativ...

(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)

docs/janssen-server/recipes/mobile-apps.md

[style] ~17-~17: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

docs/janssen-server/recipes/api-access-control/opa-access-tokens.md

[style] ~18-~18: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...t you'd like to contribute to this page in the meantime, you can get started with our [Contribu...

(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)

🪛 markdownlint-cli2 (0.18.1) docs/janssen-server/recipes/user-password-validation.md

107-107: Ordered list item prefix
Expected: 2; Actual: 5; Style: 1/2/3

(MD029, ol-prefix)

docs/script-catalog/person_authentication/other/registration/README.md

1-1: First line in a file should be a top-level heading

(MD041, first-line-heading, first-line-h1)

docs/script-catalog/update_token/update-token.md

169-169: Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

250-250: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

docs/janssen-server/planning/discovery.md

34-34: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

jans-fido2/server/src/test/java/io/jans/fido2/test/integration/README.md

152-152: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

docs/janssen-server/planning/self-service-password-2fa.md (1)

19-19: You better think twice!... Actually, never mind—this formatting fix is spot-on!

The stray list-item marker (-) has been properly removed from the start of the line, restoring the natural flow of the paragraph. This aligns perfectly with the PR's markdown linting cleanup objectives.

docs/janssen-server/recipes/passwordless.md (1)

17-17: You better think twice! Well, actually, no—this looks solid! The EOF newline has been added in compliance with the MD047 linting rule. This straightforward whitespace fix keeps the documentation clean and consistent with the repository's markdown standards.

docs/janssen-server/recipes/web-apps.md (1)

17-17: You better think twice before skipping EOF newlines, my friend! ✓

Like a wise ol' pigeon droppin' knowledge, this change is spot-on. Adding that trailing newline at the end of the file is exactly what MD047 demands. No content changes, no shenanigans—just clean, linted markdown. This aligns perfectly with the PR's mission to squash those linting gremlins across the docs.

jans-linux-setup/README.md (1)

70-70: Linting fix looks solid!

You better think twice before skipping these formatting fixes—they keep the docs clean and CI happy! Trailing spaces on line 70 have been properly removed, ensuring compliance with the MD009 (trailing spaces) linting rule. The blank line normalization between the uninstall and reinstall sections is clean and maintains proper document structure.

docs/janssen-server/recipes/forcing-reauthn.md (1)

15-17: Perfect! The EOF newline is now in place, bird friend.

You better think twice before merging without checking this: the file now correctly ends with a newline (MD047 satisfied), and no trailing spaces are lurking about. The formatting fix is solid!

One thing the linter whispered in my ear: "in the meantime" on line 17 could be tightened up—consider "now" or "currently" as a shorter alternative. However, that's outside this PR's scope and purely optional for future documentation polish.

(This is a formatting-only fix with no behavioral changes, so there's nothing to block here! 🐦)

docs/script-catalog/person_authentication/other/registration/README.md (2)

1-1: Good vibes on the whitespace cleanup! 🐦

The trailing space removal on line 1 is spot-on and directly addresses the MD009 rule as intended by this PR. You better think twice before merging without confirming the EOF newline is also properly normalized per MD047, but this particular change looks clean!

1-6: Heads up: MD041 linting hint detected — verify if pre-existing.

The static analysis output flagged MD041 (first-line-heading), which suggests this file doesn't start with a top-level heading (# Title). This rule is outside the scope of your PR objectives (MD009 and MD047), so confirm whether this is a pre-existing issue in the repository or a newly introduced concern. If it's pre-existing, no action needed for this PR; if newly introduced, consider addressing it as well.

docs/janssen-server/recipes/single-page-apps.md (1)

17-17: LGTM! You better think twice before doubting this fix, my friend! 🐦

This is a clean formatting-only change that properly normalizes the file's EOF newline, squashing that pesky MD047 lint violation. No content changes, no escapes, just clean markdown as it should be. The contribution guide link and sentence structure remain intact and correct.

One pigeon-wisdom note: The static analysis tool flagged "in the meantime" (lines 13 and 17) as potentially wordy, but that's a style concern outside the scope of this linting fix PR. If you're up for it, that could be a nice-to-have improvement in a future documentation pass—but it's not a blocker here.

docs/script-catalog/idp/idp-extension.md (1)

156-156: You better think twice before ignoring EOF newlines, my friend! ✓

Like a wise ol' pigeon, I'm here to drop some knowledge: you nailed the MD047 linting fix! The contribution guide link now properly terminates with a newline at end-of-file, exactly as the linter demands. Let's get this party rollin'!

A quick note from the static analysis crew: LanguageTool suggests "in the meantime" on this line might be wordy, but since your PR scope is purely linting/formatting fixes (MD009 & MD047), that wordiness suggestion falls outside the mission. If you fancy it, that's a nice-to-have for a separate content pass.

docs/janssen-server/recipes/inbound-saml.md (1)

17-17: Alright, here we go! The EOF newline is in place and ready to roll! 🐦

You've nailed the MD047 fix by ensuring the file ends with a proper newline. This aligns perfectly with the PR objectives to eliminate the trailing newline linting issue. No behavioral changes—just clean markdown hygiene. You better think twice before merging elsewhere without this kind of attention!

jans-auth-server/README.md (1)

1-5: Linting fix looks good!

You better think twice before rolling back this one—the formatting adjustments here are spot-on for MD009 and MD047 compliance. No functional changes to the documentation, just clean trailing-space removal and proper EOF newline handling. The README's content and structure remain intact.

docs/script-catalog/id_generator/id-generator.md (1)

128-128: EOF newline addition looks good!

You better think twice before skippin' the good vibes—and you're not! The trailing newline you've added at the end of the file addresses the MD047 linting rule perfectly. Like a wise ol' pigeon would say, every file needs a proper perch to land on, and this newline is exactly that.

Heads up on pre-existing issue (outside PR scope): The Java code example at line 121 has a syntax error—missing a comma between String and SimpleCustomProperty in the Map type parameter. Since this isn't part of your linting fix, feel free to ignore this note, but it might be worth addressing in a follow-up if documentation examples need to be syntactically correct.

docs/janssen-server/recipes/password-expirations.md (1)

19-19: You better think twice about that AI summary!

The markdown linting fix looks solid—adding that EOF newline is exactly what the doctor ordered for MD047. However, I've gotta drop some knowledge here: the AI summary mentions unrelated changes in src/calculator.py (new methods, signature updates, variable renames) that don't belong in a documentation-only PR. That's some funky context mixing right there! This documentation file change itself is clean and aligned with the PR's objectives.

One tiny note from the static analysis vibes: LanguageTool flags "in the meantime" as potentially wordy, but since that's outside the scope of your MD009/MD047 fixes, I'll leave that as optional pasta for future wordsmithing sessions.

docs/script-catalog/ssa/ssa-modify-response.md (1)

22-22: You better think twice about scope creep—this linting fix is perfect as is!

Line 22 has been cleaned up to address the markdown linting rules (trailing spaces removed and/or EOF newline normalized). The content remains unchanged and now complies with MD009 and MD047.

Note: LanguageTool flagged "in the meantime" as potentially wordy, but that's a style suggestion unrelated to the linting issues this PR targets. Keeping it as-is maintains consistency with the document's existing voice and keeps the fix focused on linting compliance.

docs/script-catalog/person_authentication/other/toopher/README.md (1)

12-12: You better think twice—but you nailed the EOF fix! 🐦

The addition of the trailing newline on Line 12 properly addresses MD047 (missing final newline). This is exactly what the linting rule requires, so we're good to go!

As a side note, LanguageTool flagged "in the meantime" on this line as potentially wordy, but that's a nice-to-have wordiness improvement outside the scope of this linting PR. If you'd like to tighten it up later, that's up to you—no blocker here.

docs/script-catalog/uma_rpt_policy/uma-rpt-policy/README.md (1)

12-12: ✓ EOF newline formatting fix aligns with PR objectives.

You better think twice before shipping docs without proper EOF newlines—this ensures compliance with MD047 linting rules. The change here looks clean and fits the broader goal of eliminating recurring lint failures across the repository.

One thing worth noting (though outside this PR's linting scope): LanguageTool flags "in the meantime" as potentially wordy on this line. Consider "meanwhile" as a shorter alternative if you're open to refining the text, but that's optional and independent of the current linting fixes.

docs/janssen-server/recipes/faq.md (1)

17-17: Looks good, drop that knowledge! ✨

You better think twice before skipping these formatting fixes—they keep the whole repo consistent! This change properly normalizes the EOF newline per the MD047 lint rule, which is exactly what the PR is all about. Let's get this party rollin' with those clean formatting standards!

Quick note on the static analysis hint: The tool flagged "in the meantime" as potentially wordy, but that's outside the scope of your MD009/MD047 lint fixes. If the content team wants to revisit that phrasing later, they can do it separately. For now, your formatting work is spot-on.

docs/janssen-server/recipes/impersonation.md (1)

17-17: LGTM! Markdown linting fix applied correctly.

The change properly normalizes the file to end with a newline, addressing the MD047 lint rule. This aligns perfectly with the PR's objectives to fix trailing spaces (MD009) and EOF newline issues (MD047) across the documentation.

docs/script-catalog/select_account/select-account.md (1)

117-170: You better think twice before you skip this one – the fix looks solid! ✅

Like a wise ol' pigeon droppin' knowledge, I gotta say: this is a clean fix for that markdown linting issue. The Java code block is now properly closed with a closing fence, and the file ends with a newline (MD047 compliance). No trailing space issues here either – documentation syntax is squeaky clean!

This straightforward formatting correction aligns perfectly with the PR objectives to eliminate recurring lint failures.

docs/janssen-server/recipes/adaptive-authn.md (1)

17-17: EOF newline added—nice!

You better think twice before skipping good formatting vibes! This file now properly ends with a newline, aligning with the MD047 linting rule. The content remains untouched and the fix is clean.

docs/janssen-server/recipes/mobile-apps.md (1)

15-17: LGTM!

The cleanup of the "Want to contribute?" section aligns well with the PR's Markdown linting objectives. The changes address trailing space and formatting issues without altering the documentation's intent or structure.

docs/script-catalog/uma_rpt_claims/uma-claims-jwt.md (1)

73-73: Approved! Linting fix looks solid, friend. 🕊️

Listen here—you've got your markdown house in order with those trailing spaces gone and EOF newline proper-like. The contribution link sits pretty at the end. That's the spirit of good documentation hygiene right there!

One heads-up, though: the static linter flagged "in the meantime" as potentially wordy. Not a blocker for this PR since you're focused on whitespace fixes, but if you're feeling inspired for a follow-up, something like "If you'd like to contribute to this page, check out our Contribution guide." could tighten it up. Your call!

docs/script-catalog/person_authentication/other/phonefactor/README.md (1)

12-12: Good vibes on the linting fix—you better think twice before adding trailing spaces next time! 🐦

You've got the EOF newline squared away here, which keeps the markdown linter happy with MD047 compliance. The line content remains unchanged and intact. The static analysis tool did whisper something about "in the meantime" being a touch wordy, but that's a style call for another day—this PR is all about the linting rules, and you've nailed it.

docs/janssen-server/planning/discovery.md (2)

34-34: You better think twice! 🐦 Scope creep alert, friend!

The change on line 34 removes punctuation (a trailing period after the code span acr_values), which is a content modification, not a lint formatting fix. Your PR objectives explicitly target MD009 (trailing spaces) and MD047 (missing final newline)—this change falls outside that scope.

Is this punctuation removal intentional, or did it slip in during the broader cleanup?

1-34: Unresolved linting issue flagged: MD022.

The static analysis tool reports an MD022 violation (headings should be surrounded by blank lines) at line 34, which is not part of your documented PR scope. Verify whether this is a pre-existing issue in the file or if it was introduced/exposed by your changes. If it's pre-existing, consider expanding the scope to fix it; if it's new, investigate the root cause.

docs/casa/plugins/bioid.md (1)

11-11: You better think twice before skippin' this—it's a solid fix!

Like droppin' bread crumbs from the roost, that trailing space has been pecked away just right. The trailing whitespace removal on line 11 is chef's kiss for MD009 compliance, and the documentation still reads smooth as butter. No fuss, no muss—this linting fix is good to go!

docs/script-catalog/spontaneous_scope/spontaneous-scope.md (1)

82-82: Hold up—let me ask ya, does this change tackle the linting goals?

Listen up, friend! Ya got me scratching my head like a wise ol' pigeon here. The PR objectives specifically target MD009 (trailing spaces) and MD047 (missing final newline), but this line change removes a list bullet - and converts it to plain text. That's a content/structural shift, not a linting fix.

A few things to think twice about:

  • Does removing this bullet actually resolve an MD009 or MD047 issue? Doesn't seem likely.
  • Is this a bonus formatting normalization across the PR, or did it sneak in by accident?
  • Should we verify this pattern is consistent if other "Want to contribute?" sections in the PR got the same treatment?

Can ya clarify if this bullet removal is intentional as part of a broader formatting pass, or if it should stay as a list item? Let me know, and I can help verify consistency across similar sections in the PR.

docs/script-catalog/uma_rpt_policy/uma-client-authz-rpt-policy/README.md (1)

12-12: LGTM! You better think twice before messin' with that EOF newline—and you nailed it! 🐦

This straightforward formatting fix adds the missing trailing newline to satisfy the MD047 linting rule. No content changes, no broken references. Clean and compliant.

docs/script-catalog/uma_rpt_policy/uma-rpt.md (1)

190-190: LGTM! Here comes the wisdom, my friend—EOF newlines keep the docs spicy and linters happy! 🐦

This formatting fix adds the missing trailing newline at the end of the file to satisfy the MD047 linting rule. All code examples (Python and Java) remain intact and correct. No content changes, no behavioral impact.

docs/casa/developer/overview.md (2)

52-52: You better think twice before merging... j/k, this looks squeaky clean!

The trailing whitespace removals on lines 52 and 86 are spot-on MD009 fixes. No content changes whatsoever—just sweeping out the invisible dust. These mechanical fixes align perfectly with the PR objectives to eliminate recurring lint failures.

Also applies to: 86-86

150-151: EOF newline looks good to go!

The file structure terminates properly, aligning with MD047 requirements. The final newline is in place, so linters won't squawk about that one. This is exactly what we want when addressing documentation formatting.

jans-auth-server/agama/README.md (2)

4-4: Trailing space removal aligns with PR objectives.

The modification on line 4 removes a trailing space, which correctly addresses the MD009 linting rule as stated in the PR objectives.

Note on static analysis hints: The LanguageTool checks flagged two pre-existing content issues (wordiness in "by means of" and missing hyphen in "domain specific language"). These are outside the scope of this PR's linting-only fix. If you'd like to improve documentation quality, I'd recommend opening a separate documentation-enhancement issue to address these style/grammar concerns without conflating them with whitespace normalization fixes.

12-12: All good—your file is MD047 compliant! ✓

The verification confirms that jans-auth-server/agama/README.md correctly ends with a newline character, fully satisfying the linting requirement. No further action needed.

docs/casa/administration/faq.md (1)

33-33: You better think twice! There's a mismatch here that needs clarification, friend.

The AI summary claims "Removed leading list markers to convert dashed list items into standard Markdown content," but the current annotated code shows these lines as regular paragraph text with no visible list markers. However, the PR objectives state this should address MD009 (trailing spaces) and MD047 (EOF newline) linting rules—quite different from list marker removal.

This suggests either:

  1. The AI summary is incorrect or misleading about the nature of these changes
  2. The annotation doesn't fully display trailing spaces or EOF state

Like a wise ol' pigeon, I gotta know: are these changes actually removing trailing spaces and ensuring proper EOF newlines (per the PR title), or are they restructuring list items (per the summary)?

Also applies to: 52-52, 66-66, 78-78

docs/janssen-server/recipes/api-access-control/README.md (1)

1-14: Perfect harmony with the PR objectives! ✓

This file gets a trailing newline added at EOF, cleanly addressing the MD047 rule (files should end with a single newline character). No content changes, just the formatting fix we're rolling with.

docs/janssen-server/recipes/api-access-control/user-claims-tokens.md (1)

1-18: File gets the newline treatment! ✓

The EOF newline is being added here, fixing the MD047 (files should end with a single newline character) violation. Content stays pristine—just a formatting cleanup that keeps our linter happy.

docs/janssen-server/recipes/device-flow-config.md (1)

1-20: Trailing newline incoming! ✓

Another EOF newline fix addressing MD047 (single-trailing-newline). Content untouched, formatting improved—that's the recipe for a clean lint run.

docs/janssen-server/planning/vm-single-instance.md (1)

32-33: Sentence consolidation—wise choice! ✓

Line 32-33 gets unwrapped here, likely cleaning up MD009 (trailing spaces at end of lines) from the previous line. The meaning stays intact while the formatting improves. Neat and tidy.

docs/janssen-server/recipes/api-access-control/client-credential-grant-flow.md (1)

1-18: EOF newline secured! ✓

Trailing newline added to fix MD047 (files should end with a single newline character). Clean, simple, and in line with the PR's mission.

docs/janssen-server/recipes/api-access-control/software-statements.md (1)

1-18: Newline added—linter be pleased! ✓

EOF newline fix addressing MD047 (single-trailing-newline). Content remains solid, formatting gets a boost.

docs/janssen-server/recipes/apps/magento.md (1)

1-18: Trailing newline locked in! ✓

Another file gets the EOF newline treatment, fixing MD047 (files should end with a single newline character). Formatting improved, content safe and sound.

docs/janssen-server/recipes/apps/moodle.md (1)

1-18: Last one's a charm! ✓

EOF newline added to fix MD047 (files should end with a single newline character). Clean wrap-up to a straightforward PR focused on linting hygiene.

docs/janssen-server/recipes/apps/kafka.md (1)

18-18: You better think twice... then approve it! ✨

Like a wise ol' pigeon droppin' wisdom from the rooftop, I gotta say this formatting fix hits the mark. Adding that proper newline at EOF keeps the linting spirits happy and prevents those pesky MD047 violations from crashin' the CI party again. Clean, simple, no shenanigans—just pure markdown hygiene.

docs/janssen-server/recipes/api-access-control/openapi-best-practice.md (1)

18-18: This formatting fix gets the green light—no nonsense! 🎯

The newline's in place, MD047 is satisfied, and the CI gods shall be appeased. Pure formatting work, pure goodness. The party rolls on!

docs/janssen-server/recipes/api-access-control/scope-access.md (1)

18-18: Let's get this party rollin'—approval incoming! 🐦

Another clean EOF newline fix? Ya betcha! No trailing space drama, no missing newline chaos—just solid, predictable markdown hygiene that makes the linter smile. This is exactly how we keep those CI checks from turnin' sour.

docs/janssen-server/recipes/apps/drupal.md (1)

18-18: Solid work, friend! This fix is ready to roll! ✅

Adding that trailing newline like a boss. MD047 compliance achieved, linter appeased, CI stays happy. You know what they say—a file without a newline is like a pigeon without wings. Now this doc can take flight!

docs/janssen-server/recipes/apps/README.md (1)

14-14: Another one bites the dust—properly formatted! 🎉

EOF newline in place, README breathes easy, linter stays chill. This is the kind of consistency that keeps a repo runnin' smooth as butter. No drama, just pure markdown beauty.

docs/janssen-server/recipes/api-access-control/opa-access-tokens.md (1)

18-18: Perfect finale—formatting locked and loaded! 🏁

That newline's sittin' pretty at the EOF, MD047's got its victory lap, and the CI checks won't be crashing down on ya next time. This is what I call a well-executed cleanup. Good vibes all around!

docs/script-catalog/update_token/update-token.md (1)

169-169: You better think twice! 🕊️ The review comment flagged violations that don't actually exist—it's based on incorrect assumptions.

I ran the actual markdownlint-cli2 tool on the file, and here's what the real linting output shows:

The file has 116 linting errors, but they're different from what the review claimed:

  • No MD019 violation at line 169 (review incorrectly claimed it)
  • No MD022 violation at line 250 (review incorrectly claimed it)
  • Actual violations: MD013 (line-length), MD040 (fenced-code-language), MD029 (ol-prefix), MD007/MD030 (list formatting), MD010 (hard-tabs)

The review comment appears to have made up violations rather than running actual linting verification. This gives misleading feedback to the developer about what needs to be fixed.

Likely an incorrect or invalid review comment.

docs/script-catalog/uma_claims_gathering/uma-claims-web.md (1)

131-131: ---

✓ Trailing spaces and final newline verified—no further action needed.

The verification confirms both linting issues are resolved:

  • MD009 (trailing spaces): rg search found zero matches for trailing whitespace—all trailing spaces have been removed.
  • MD047 (missing final newline): The file correctly ends with a newline character, as confirmed by wc -l reporting 131 lines.

You better think twice, 'cause you're rolling with solid fixes here! The party's complete and your markdown is squeaky clean!

docs/janssen-server/recipes/user-password-validation.md (1)

107-107: You better think twice! — But hold up, that original review comment just got debunked by the evidence.

The verification shows the file passes with 0 linting errors from markdownlint-cli2. That alleged MD029 error on line 107? It doesn't exist. Looks like the PR successfully fixed what it set out to fix (MD009 and MD047) without any linting baggage. No new issues introduced, no pre-existing ones either. The file is squeaky clean!

Likely an incorrect or invalid review comment.

docs/script-catalog/person_authentication/other/compromised_password/readme.md (1)

7-7: LGTM! You better think twice before letting those missing newlines back in! 🐦

This EOF newline addition aligns perfectly with the MD047 linting rule fix across the repository.

docs/script-catalog/introspection/introspection-role-based-scope/README.md (1)

11-11: LGTM! The party's rolling with proper EOF formatting! 🎉

EOF newline addition addresses MD047. Note: The static analysis style hint about "in the meantime" is outside the scope of this formatting-only PR and can be addressed separately if desired.

docs/script-catalog/person_authentication/yubicloud-external-authenticator/README.md (1)

12-12: LGTM! Steady as the pigeon dropping knowledge! 🐦

EOF newline properly added for MD047 compliance. Static analysis style suggestion noted but out of scope for this formatting PR.

docs/script-catalog/person_authentication/user-cert-external-authenticator/README.md (1)

12-12: LGTM! You better think twice before shipping without proper EOF! 🎯

EOF newline addition addresses MD047 linting requirement. Style feedback from static analysis is editorial in nature and outside this formatting-focused PR.

docs/script-catalog/person_authentication/smpp-2fa/README.md (1)

12-12: LGTM! Let's get this party rollin' with proper formatting! 🚀

EOF newline addition for MD047 compliance. Style suggestions from static analysis are outside the scope of this formatting-only PR.

docs/script-catalog/person_authentication/other/idfirst/README.md (2)

21-22: LGTM! The readability improvement makes this good vibes! 📖

The line reflow at Line 21 improves clarity of the instruction without changing semantics. Good move!

37-37: LGTM! EOF newline is in place! 🐦

EOF newline addition addresses MD047 compliance. Note: LanguageTool suggests "low-level" (hyphenated) for the compound adjective, but that content edit is outside the scope of this formatting-focused PR and can be addressed in a separate editorial pass if desired.

docs/script-catalog/person_authentication/otp-external-authenticator/README.md (1)

12-12: LGTM! Ready to have some fun with proper formatting! 🎉

EOF newline addition addresses MD047 linting requirement. Style feedback is outside the scope of this formatting-specific PR.

docs/script-catalog/person_authentication/other/wikid/README.md (1)

12-12: LGTM! That's the way, friend! 🐦 All good vibes on this final one!

EOF newline addition for MD047 compliance. Static analysis style suggestion noted but outside the scope of this formatting-only effort.

docs/script-catalog/person_authentication/agama-bridge/README.md (1)

11-11: Verify scope: bullet point removal appears out of alignment with PR objectives.

You better think twice! The removal of the leading dash from line 11 converts this markdown bullet into plain text. However, the PR objectives target MD009 (trailing spaces) and MD047 (missing final newline)—not bullet-point formatting. This change appears in multiple files with the same pattern (agama-bridge, revoke-token, and others), suggesting it's systematic.

Is this bullet removal intentional and tied to a markdown linting rule, or is it an unintended side effect? If intentional, please clarify the relationship to the stated linting fixes.

docs/script-catalog/person_authentication/other/wwpass/README.md (1)

19-19: ✓ EOF newline fix looks good.

The trailing newline addition at end-of-file correctly addresses MD047. No concerns here, my friend!

docs/script-catalog/introspection/introspection-custom-parameters/README.md (1)

11-11: ✓ EOF newline normalization for MD047 is correct.

Clean fix here! The trailing newline ensures the file ends properly per MD047.

docs/script-catalog/post_authn/post-authentication.md (1)

128-128: ✓ EOF newline fix is appropriate.

The trailing newline after the closing code fence correctly satisfies MD047. Solid work!

docs/script-catalog/introspection/introspection/README.md (1)

11-11: ✓ EOF newline ensures MD047 compliance.

The trailing newline is now in place. Looking good!

docs/script-catalog/person_authentication/README.md (1)

5-5: ✓ EOF newline addition is correct.

The trailing newline at end-of-file satisfies MD047. All good here!

docs/script-catalog/revoke_token/revoke-token.md (1)

125-125: Verify scope: bullet point removal inconsistent with stated PR objectives.

Similar to the agama-bridge file, line 125 removes the leading dash from the contribution line. This converts a markdown bullet into plain text—a content change that doesn't align with the PR's stated goals of fixing MD009 (trailing spaces) and MD047 (missing final newline).

This bullet removal appears in multiple files systematically. Is this change tied to a specific markdown linting rule, or should it be excluded from this linting-focused PR?

docs/script-catalog/persistence_extension/persistence.md (1)

105-105: Like a wise ol' pigeon droppin' knowledge, that EOF newline fix hits different! LGTM.

The final newline addition (line 105) aligns perfectly with the MD047 linting rule. These whitespace and formatting normalizations are exactly what the PR set out to do.

docs/janssen-server/recipes/registration.md (1)

19-19: Verify whether the dash removal was intentional and aligns with PR scope.

The AI summary indicates a leading dash was removed from this line (converting a list item to plain text), but that's a structural change unrelated to the stated PR objectives of fixing MD009 (trailing spaces) and MD047 (missing final newline). Before merging, confirm:

  1. Was the dash actually removed as part of this PR change?
  2. If yes, is that structural modification intentional and within scope?
  3. The "in the meantime" wording is a nice-to-have style refinement—optional, not required.