feat(orm): add postgres-socket-factory by yurem · Pull Request #12827 · JanssenProject/jans (original) (raw)
📝 Walkthrough
Walkthrough
Adds Google Cloud SQL socket factory dependencies for PostgreSQL to the Maven bill of materials and ORM SQL module. Introduces a new postgresql-socket.version property and includes the socket factory JAR alongside existing PostgreSQL dependencies to enable cloud-native deployment scenarios.
Changes
| Cohort / File(s) | Summary |
|---|---|
| Cloud SQL Socket Factory Dependencies jans-bom/pom.xml, jans-orm/sql/pom.xml | Adds com.google.cloud.sql:postgres-socket-factory dependency. Introduces postgresql-socket.version property in BOM for centralized version management and applies the socket factory dependency in ORM SQL module. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
- Verify the version property is properly defined and referenced across both POM files
- Confirm the dependency placement and ordering within POM structure is correct
- Check that the socket factory dependency version aligns with the organization's Cloud SQL compatibility requirements
Possibly related PRs
- feat(orm): add mysql-socket dependecy #12824 — Adds equivalent MySQL socket factory dependencies following the same pattern for cloud-native support.
Suggested labels
comp-jans-orm, kind-feature, comp-jans-bom
Suggested reviewers
- yuriyz
- yuriyzz
Pre-merge checks and finishing touches
❌ Failed checks (1 inconclusive)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check | ❓ Inconclusive | The PR adds the postgres-socket-factory dependency as referenced in issue #12823, but does not demonstrate how this alone resolves the logging loss problem described. | Clarify in the PR description how adding the socket factory dependency resolves the missing logs issue, or verify if additional configuration changes are needed. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately describes the main change: adding postgres-socket-factory dependency to the ORM module. |
| Description check | ✅ Passed | The PR description references the linked issue (#12823) and confirms no documentation impact, but lacks implementation details about how the socket factory fixes the logging issue. |
| Out of Scope Changes check | ✅ Passed | All changes are directly related to adding the postgres-socket-factory dependency as specified in the linked issue. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches 🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
postgres_socket
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.