feat(jans-auth): remove old jackson2 dependency by yurem · Pull Request #12886 · JanssenProject/jans (original) (raw)

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e1646a and bb601fb.

📒 Files selected for processing (4) 

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12736
File: jans-config-api/plugins/jans-link-plugin/src/main/java/io/jans/configapi/plugin/link/util/Constants.java:16-17
Timestamp: 2025-12-22T15:34:36.425Z
Learning: In the Jans project's config-api component, there is an intentional shift in OAuth scope URL naming convention to exclude the "jans-" prefix from scope identifiers. Scope URLs like `https://jans.io/oauth/config/link.admin` (without "jans-link") are preferred over `https://jans.io/oauth/config/jans-link.admin`. This is part of a deliberate renaming effort to exclude the project name from scope names.

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12847
File: jans-config-api/docs/jans-config-api-swagger.yaml:15497-15498
Timestamp: 2025-12-17T13:07:08.750Z
Learning: When reviewing components like `jans-auth`, `jans-fido2`, `jans-lock` in the JanssenProject/jans repository, raise issues about missing property descriptions in API model classes, as these descriptions will be reflected in the auto-generated Swagger specifications.

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12847
File: jans-config-api/docs/jans-config-api-swagger.yaml:0-0
Timestamp: 2025-12-17T12:44:48.624Z
Learning: In the jans-config-api project, the model class referenced in the Swagger file at jans-config-api/docs/jans-config-api-swagger.yaml (around line 17747 with properties like `logoutStatusJwt` and `accessToken`) is out of scope of Config-API and is managed by another component.

📚 Learning: 2025-12-18T13:12:06.219Z 

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12736
File: jans-config-api/docs/jans-config-api-swagger.yaml:14949-14965
Timestamp: 2025-12-18T13:12:06.219Z
Learning: In the jans-config-api project, the swagger spec file `jans-config-api/docs/jans-config-api-swagger.yaml` is auto-generated from the `jans-core/service/src/main/java/io/jans/model/JansAttribute.java` model class. Properties in the swagger spec correspond to getter methods in the Java class, including computed properties like `adminCanEdit` (from `isAdminCanEdit()`), `userCanView` (from `isUserCanView()`), etc.

Applied to files:

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12704
File: jans-config-api/docs/jans-config-api-swagger.yaml:17540-17546
Timestamp: 2025-11-18T07:43:55.761Z
Learning: The file `jans-config-api/docs/jans-config-api-swagger.yaml` is auto-generated with dependent modules changes and metadata. The config API does not override it.

Applied to files:

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12736
File: jans-config-api/plugins/jans-link-plugin/src/main/java/io/jans/configapi/plugin/link/util/Constants.java:16-17
Timestamp: 2025-12-22T15:34:36.425Z
Learning: In the Jans project's config-api component, there is an intentional shift in OAuth scope URL naming convention to exclude the "jans-" prefix from scope identifiers. Scope URLs like `https://jans.io/oauth/config/link.admin` (without "jans-link") are preferred over `https://jans.io/oauth/config/jans-link.admin`. This is part of a deliberate renaming effort to exclude the project name from scope names.

Applied to files:

Learnt from: pujavs
Repo: JanssenProject/jans PR: 12847
File: jans-config-api/docs/jans-config-api-swagger.yaml:0-0
Timestamp: 2025-12-17T12:44:48.624Z
Learning: In the jans-config-api project, the model class referenced in the Swagger file at jans-config-api/docs/jans-config-api-swagger.yaml (around line 17747 with properties like `logoutStatusJwt` and `accessToken`) is out of scope of Config-API and is managed by another component.

Applied to files:

jans-scim/service/src/main/java/io/jans/scim/service/ConfigurationFactory.java (1)

95-95: The filename jans-scim.properties follows the established naming convention across all services in the codebase (jans-fido2.properties, jans-lock.properties, etc.). No evidence of a previous scim.properties filename exists in the repository history or current code. This is not a breaking change but rather consistent with project conventions. The code safely handles missing configuration files through null checks.

Likely an incorrect or invalid review comment.