feat(config-api): client operation for clientSecret and removed unused dependency by pujavs · Pull Request #13572 · JanssenProject/jans (original) (raw)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 21710d39-3478-4518-b6f6-ff42d989e9dd

📥 Commits

Reviewing files that changed from the base of the PR and between f41162e and 226faae.

📒 Files selected for processing (6)

jans-config-api/docs/jans-config-api-swagger.yaml
jans-config-api/plugins/docs/fido2-plugin-swagger.yaml
jans-config-api/server/pom.xml
jans-config-api/server/src/main/java/io/jans/configapi/rest/resource/auth/ClientsResource.java
jans-config-api/shared/pom.xml
jans-config-api/shared/src/main/java/io/jans/configapi/core/util/Jackson.java 💤 Files with no reviewable changes (1)
jans-config-api/shared/pom.xml

📝 Walkthrough

Walkthrough

The pull request modifies OpenAPI/Swagger schema definitions by reordering properties and updating metrics schema structures, removes several Maven dependencies (CDI/Weld and RestEasy providers), and reduces debug logging statements in patch-related Java classes to avoid logging sensitive data.

Changes

Cohort / File(s)	Summary
OpenAPI Schema Updates jans-config-api/docs/jans-config-api-swagger.yaml, jans-config-api/plugins/docs/fido2-plugin-swagger.yaml	Reordered schema properties in PatchRequest and Fido2MetricsAggregation. Added fapi boolean property to PatchRequest and new metrics objects (errorCounts, deviceTypes, performanceMetrics). Reorganized authentication-related property ordering including accessToken and multiple failure/success count fields.
Maven Dependency Removals jans-config-api/server/pom.xml, jans-config-api/shared/pom.xml	Removed CDI/Weld implementation dependencies (weld-servlet-core, weld-core-impl), Jakarta EL and EJB APIs, and RestEasy JSON provider packages (resteasy-jackson2-provider, resteasy-json-p-provider) from dependency declarations.
Logging Modifications jans-config-api/server/src/main/java/io/jans/configapi/rest/resource/auth/ClientsResource.java, jans-config-api/shared/src/main/java/io/jans/configapi/core/util/Jackson.java	Removed or reduced debug logging statements related to patch operations and JSON processing. Modified patchClient to log only client inum instead of raw patch string; removed verbose debug logs from Jackson utility methods (applyPatch, isFieldPresent, getJsonPatch, applyJsonPatch).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

fix(config-api): client secret getting encrypted #12930 — Modifies ClientsResource patch operations and client-secret encryption logic that could interact with logging changes in the same patchClient method.
feat(jans-config-api): configuration changes to handle clientSecret in response #12847 — Edits the same ClientsResource and Jackson classes with patch-related logging and field-detection modifications.

Suggested labels

comp-jans-config-api, kind-feature, kind-dependencies

Suggested reviewers

yuriyz
yurem
yuriyzz 🚥 Pre-merge checks | ✅ 3 ✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title directly describes the main changes: adding a client operation for clientSecret (PATCH method) and removing unused dependencies.
Description check	✅ Passed	The description identifies both target issues (#8370 and #11328), mentions implementation approach (client operation for clientSecret and unused dependency removal), and includes the required checklist section.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 📝 Generate docstrings

Create stacked PR
Commit on current branch 🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch jans-config-api-2.0.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share