feat(charts): support gateway api in janssen-aio by misba7 · Pull Request #12907 · JanssenProject/jans (original) (raw)
📝 Walkthrough
Walkthrough
Adds Gateway API support to the janssen-all-in-one Helm chart: a new certManager.gatewayApi values block and a Helm template that renders a Gateway and multiple HTTPRoute resources with conditional listeners, TLS, redirects, rewrites, and backend refs driven by chart values (hosts, feature flags).
Changes
| Cohort / File(s) | Summary |
|---|---|
| Values: Gateway API configuration charts/janssen-all-in-one/values.yaml | Added certManager.gatewayApi block with fields: enabled, gatewayClassName, name, tlsSecretName, gatewayLabels, gatewayAnnotations, routeLabels, routeAnnotations. Small non-functional comment edits in nginx-ingress service section. |
| Templates: Gateway + HTTPRoute charts/janssen-all-in-one/templates/gateway-api.yaml | New Helm template creating a Gateway (HTTP/HTTPS listeners, TLS) and multiple HTTPRoute resources. Routes are assembled via many conditional blocks to emit path-prefix matches, rewrites, backendRefs, and HTTP->HTTPS redirects based on chart feature flags and values.fqdn. |
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
Pre-merge checks
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | ⚠️ Warning | The PR description is incomplete. It only contains 'closes #12834' but lacks required sections like Implementation Details, testing confirmation, and documentation checklist from the template. | Fill in all required template sections including Implementation Details, testing/analysis confirmation, and complete the documentation checklist before merging. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title 'feat(charts): support gateway api in janssen-aio' clearly and concisely describes the main change: adding Gateway API support to the janssen-aio Helm charts. |
| Linked Issues check | ✅ Passed | The linked issue #12834 requests adding Kubernetes Gateway support to the charts, and the PR adds a gateway-api.yaml template with Gateway and HTTPRoute resources that implement this functionality. |
| Out of Scope Changes check | ✅ Passed | The PR introduces gateway API configuration and templates that align with the stated objective. Minor comment updates in values.yaml are related cleanup work within scope. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.