fix(cloud-native): remove admin-ui plugin from charts by iromli · Pull Request #13096 · JanssenProject/jans (original) (raw)
📝 Walkthrough
Walkthrough
The pull request removes the "admin-ui" plugin from the default enabled plugins list in the janssen-all-in-one Helm chart. The plugin configuration is updated from "admin-ui,fido2,scim,user-mgt" to "fido2,scim,user-mgt" in both the documentation and values configuration files.
Changes
| Cohort / File(s) | Summary |
|---|---|
| Admin-UI plugin removal charts/janssen-all-in-one/README.md, charts/janssen-all-in-one/values.yaml | Removed "admin-ui" from the default config-api.plugins comma-separated list. Updated in documentation and configuration values to reflect that only fido2, scim, and user-mgt plugins are enabled by default. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested labels
kind-bug, comp-charts-jans
Suggested reviewers
- moabu 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and specifically describes the main change: removing the admin-ui plugin from charts in the cloud-native setup. |
| Description check | ✅ Passed | The PR description follows the template with all required sections completed, including target issue reference (#13095), checklist confirmations, and documentation impact statement. |
| Linked Issues check | ✅ Passed | The code changes directly fulfill the objective stated in issue #13095: removing the admin-ui plugin from the jans-config-api charts to prevent filtering errors. |
| Out of Scope Changes check | ✅ Passed | All changes are scoped to removing the admin-ui plugin from chart configuration files, which aligns with the stated objective in issue #13095. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.