fix: correct urls in Chart.yaml and README by misba7 · Pull Request #14146 · JanssenProject/jans (original) (raw)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e6caaf07-d50a-4881-9518-fb99b013c80a

📥 Commits

Reviewing files that changed from the base of the PR and between 16bb8d8 and 7c879f2.

📒 Files selected for processing (2)

📝 Walkthrough

Walkthrough

This PR standardizes upstream source repository references across Janssen Helm charts by updating Chart.yaml sources metadata and README "Source Code" links to explicit GitHub monorepo paths (tree/main) and adding chart-specific source entries where missing.

Changes

Helm Chart Source URL Standardization

Layer / File(s) Summary
Top-level Janssen Helm charts metadata charts/janssen-all-in-one/Chart.yaml, charts/janssen-all-in-one/README.md, charts/janssen/Chart.yaml, charts/janssen/README.md Top-level charts gain or expand GitHub source references and README links updated to point to chart directories on the main branch.
Core service subcharts: auth-server and config charts/janssen/charts/auth-server-key-rotation/Chart.yaml, charts/janssen/charts/auth-server-key-rotation/README.md, charts/janssen/charts/auth-server/Chart.yaml, charts/janssen/charts/auth-server/README.md, charts/janssen/charts/config-api/Chart.yaml, charts/janssen/charts/config-api/README.md, charts/janssen/charts/config/Chart.yaml, charts/janssen/charts/config/README.md Auth-server (and key-rotation), config-api, and config subcharts updated to reference JanssenProject/jans/tree/main/... paths; README source links adjusted accordingly.
Feature and integration subcharts: casa, cleanup, fido2, persistence, scim charts/janssen/charts/casa/Chart.yaml, charts/janssen/charts/casa/README.md, charts/janssen/charts/cleanup/Chart.yaml, charts/janssen/charts/cleanup/README.md, charts/janssen/charts/fido2/Chart.yaml, charts/janssen/charts/fido2/README.md, charts/janssen/charts/persistence/Chart.yaml, charts/janssen/charts/persistence/README.md, charts/janssen/charts/scim/Chart.yaml, charts/janssen/charts/scim/README.md Casa, cleanup, FIDO2, persistence, and SCIM subcharts standardized to use explicit tree/main GitHub URLs for application and docker-component repositories; READMEs updated.
External integration chart: Shibboleth Identity Provider charts/janssen/charts/shibboleth-idp/Chart.yaml, charts/janssen/charts/shibboleth-idp/README.md Shibboleth IdP chart sources changed from shibboleth.net to shibboleth.atlassian.net wiki overview links.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

area-documentation, comp-charts-jans, comp-docs

Suggested reviewers

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal (only 'closes #14145') and lacks required template sections including target issue details, implementation details, and testing/documentation checklist confirmations. Complete the PR description using the template: add issue details under 'Target issue', include implementation approach under 'Implementation Details', and check required testing and documentation checkboxes.
Linked Issues check ❓ Inconclusive The linked issue #14145 has no description content available to validate whether the PR's URL corrections meet stated objectives or requirements. Verify the PR changes against issue #14145's detailed requirements once issue details are available or clarified by the maintainers.

✅ Passed checks (3 passed)

Check name Status Explanation
Title check ✅ Passed The title 'fix: correct urls in Chart.yaml and README' directly and specifically describes the main change: updating URLs in Chart.yaml and README files across multiple Helm charts.
Out of Scope Changes check ✅ Passed All changes consistently correct URLs in Chart.yaml and README files across multiple Helm charts, staying focused on metadata and documentation updates with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.