chore: sync tarp with the latest cedarling changes by duttarnab · Pull Request #14182 · JanssenProject/jans (original) (raw)
📝 Walkthrough
Walkthrough
Bumps Cedarling and uuid versions and refactors UnsignedAuthzForm to use a single principal object (state, storage, request, reset, UI, and JSON editor) instead of an array of principals.
Changes
Cedarling sync and principal refactoring
| Layer / File(s) | Summary |
|---|---|
| Dependency updates demos/janssen-tarp/browser-extension/package.json | Cedarling WASM (@janssenproject/cedarling_wasm 0.0.387→0.0.404) and uuid (13.0.0→14.0.0) are bumped. |
| UnsignedAuthzForm principal refactoring demos/janssen-tarp/browser-extension/src/features/cedarling/components/UnsignedAuthzForm.tsx | Form state, storage restoration, request construction, resetInputs, UI descriptive text, and JsonEditor binding are updated to use principal: Record<string, unknown> (default {}) instead of principals: unknown[]. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
- JanssenProject/jans#13741: Also updates
@janssenproject/cedarling_wasmdependency.
Suggested labels
kind-bug, comp-jans-cedarling
Suggested reviewers
- faisalsiddique4400
- moabu
- yuremm 🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | ⚠️ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
| Description check | ❓ Inconclusive | The PR description includes the target issue reference (#14181) and confirms no docs impact, but the Implementation Details section is empty and the Test and Document checklists remain unchecked, indicating incomplete documentation of the implementation approach. | Add implementation details explaining the principal datatype change from array to object and its impact on the UnsignedAuthzForm component. |
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title 'chore: sync tarp with the latest cedarling changes' clearly and directly describes the main purpose of the PR, matching the actual changes in dependency versions and the authorization form refactoring. |
| Linked Issues check | ✅ Passed | The PR successfully addresses both requirements from issue #14181: cedarling dependency was updated from 0.0.387 to 0.0.404 (and uuid from 13.0.0 to 14.0.0), and the UnsignedAuthzForm component was refactored to handle the principal datatype change from array to object. |
| Out of Scope Changes check | ✅ Passed | All code changes are directly related to the PR objectives: updating cedarling dependencies and fixing the unsigned authorization form for the principal datatype change. No unrelated or extraneous changes were introduced. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches 📝 Generate docstrings
- Create stacked PR
- Commit on current branch 🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
jans-tarp-14181
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.