fix(cloud-native): update pycloudlib to handle invalid multi-parts secret by iromli · Pull Request #14191 · JanssenProject/jans (original) (raw)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: eb5a250e-bc1f-4cb6-b79c-7d1202205f37

📥 Commits

Reviewing files that changed from the base of the PR and between f5b81af and ffad392.

📒 Files selected for processing (10)

docker-jans-all-in-one/Dockerfile
docker-jans-auth-server/Dockerfile
docker-jans-casa/Dockerfile
docker-jans-cloudtools/Dockerfile
docker-jans-config-api/Dockerfile
docker-jans-configurator/Dockerfile
docker-jans-fido2/Dockerfile
docker-jans-link/Dockerfile
docker-jans-persistence-loader/Dockerfile
docker-jans-scim/Dockerfile

📝 Walkthrough

Walkthrough

Ten Docker component Dockerfiles are updated to pin a newer Jans monorepo revision. Each JANS_SOURCE_VERSION environment variable is changed to commit f5b81afbb2be4834e9caf2e518af9f5ec42f4dd9, affecting which repository state is sparse-checked out and whose assets are copied into each Docker image during the build.

Changes

Monorepo Version Pin Update

Layer / File(s)	Summary
JANS_SOURCE_VERSION update across all Docker images docker-jans-all-in-one/Dockerfile, docker-jans-auth-server/Dockerfile, docker-jans-casa/Dockerfile, docker-jans-cloudtools/Dockerfile, docker-jans-config-api/Dockerfile, docker-jans-configurator/Dockerfile, docker-jans-fido2/Dockerfile, docker-jans-link/Dockerfile, docker-jans-persistence-loader/Dockerfile, docker-jans-scim/Dockerfile	The build-time JANS_SOURCE_VERSION is pinned to commit f5b81afbb2be4834e9caf2e518af9f5ec42f4dd9 across all ten Docker component Dockerfiles. This single change controls which Jans monorepo revision is sparse-checked out during the asset synchronization step in each image build.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

JanssenProject/jans#12483: Both PRs update the build-time JANS_SOURCE_VERSION in the same Dockerfiles to change which monorepo revision is checked out for asset sync.
JanssenProject/jans#13750: Both PRs update the same Docker build pin ENV JANS_SOURCE_VERSION in the Jans component Dockerfiles to switch which monorepo revision is sparse-checked-out for image assets.
JanssenProject/jans#14159: Both PRs only update the Docker build-time JANS_SOURCE_VERSION (the monorepo revision checked out for asset sync) in the docker-jans-*/Dockerfile files.

Suggested labels

kind-dependencies, comp-docker-jans-persistence-loader, comp-docker-jans-auth-server, comp-docker-jans-config-api, comp-docker-jans-configurator, comp-docker-jans-fido2, comp-docker-jans-scim, comp-docker-jans-link, comp-docker-jans-all-in-one, comp-docker-jans-casa, comp-docker-jans-cloudtools

Suggested reviewers

moabu
misba7 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(cloud-native): update pycloudlib to handle invalid multi-parts secret' clearly describes the main change: updating pycloudlib to handle invalid multi-part secrets.
Description check	✅ Passed	The PR description follows the required template with sections for Prepare, Target issue (#14190), Implementation details, and Test/Document checklist. However, Implementation Details section is empty.
Linked Issues check	✅ Passed	The PR changes update JANS_SOURCE_VERSION across 10 Dockerfiles to commit f5b81af, which should address the pycloudlib multi-part secret handling requirement in issue #14190.
Out of Scope Changes check	✅ Passed	All changes are in-scope: 10 Dockerfiles updated with the same JANS_SOURCE_VERSION commit hash, directly supporting the pycloudlib update objective for handling invalid multi-part secrets.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cn-image-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share