Correct vocabulary for person counts is used by ssuvorov-fls · Pull Request #2860 · OHDSI/Atlas (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Conversation
| optionsText: 'sourceName', |
|---|
| optionsValue: 'sourceKey', |
| value: currentResultSource, |
| value: currentResultSource().sourceKey, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like 1currentResultSource()1 is an observable to a Source object, but should we be binding the dropdown to a full-source object instead of just a observable that stores what the current source selection? I can't tell from this review, but what is in currentResultSource() and should we be updating the 1 field in it (sourceKey) when instead it would make more sense to just store the currentResultSource's key? Maybe this var should be called currentResultSourceKey?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed currentResultSource, now only currentResultSourceKey is used for search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
