Make ERC1967Upgrades a library instead of an abstract contract by Amxx · Pull Request #4325 · OpenZeppelin/openzeppelin-contracts (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should be able to remove this in 5.0 since we are not guaranteeing upgradeability from 4.x versions.

Additionally, I don't understand why this function is in ERC1967Upgrade. It's not really ERC-1967 and if we rename this to ERC1967Utils this becomes even clearer IMO.

It's not exactly ERC-1822 either because we never submitted an update to extend the ERC with the semantics of proxiableUUID we're using.

I don't see why we can't put this logic directly inside UUPSUpgradeable. What do you think?