Add GovernorTimelockControl address to TimelockController salt by ernestognw · Pull Request #4432 · OpenZeppelin/openzeppelin-contracts (original) (raw)

For the record, I don't think its a serious issue that 2 governors that use the same TimelockController would submit the same proposal with the same description.

And if it ever happens ... then one could argue that they are the same proposal and should only be execute once.

In fact that might actually be a feature: you have multiple governor with different rule, you propose the same thing on both side, any governor can decide to execute it alone, but you have a guarantee that it won't be execute twice if both governor vote yes.

Anyway, If we want to do it, then I think this PR is good. I'm still not convinced we need this feature though ... but I also thing its not adding any security issue.