Remove non-standard increaseAllowance and decreaseAllowance from ERC20 by Amxx · Pull Request #4585 · OpenZeppelin/openzeppelin-contracts (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
(See discussion in issue)
Fixes #4583
PR Checklist
- Tests
- Documentation
- Changeset entry (run
npx changeset add)
Remove non-standard functions (increasseAllowance and decreasseAllowance) from ERC20. Remove non-standard increaseAllowance and decreaseAllowance from ERC20
Should we add any documentation about the existence of increase/decreaseAllowance in previous versions?
Regarding documentation, my thinking was that we'd want to document for wallets that there is an alternative way to change allowance and any protections to approve should also be used with increaseAllowance. After discussing this, we don't think our documentation is the best place for this warning, and we're considering publishing a blog post about it.
This was referenced
Sep 14, 2023
Should we add any documentation about the existence of
increase/decreaseAllowancein previous versions?
We definitely shoud. I came here because the official open zeppelin docs say that the functions exist:
Yet, I couldn't find them in the source code, hence posting here!
Should we add any documentation about the existence of
increase/decreaseAllowancein previous versions?We definitely shoud. I came here because the official open zeppelin docs say that the functions exist:
Yet, I couldn't find them in the source code, hence posting here!
You're looking at v4 sir. Please change the documentation version to 5.x 😄
This was referenced
Jun 15, 2024
This was referenced
Jul 9, 2024
This was referenced
Sep 11, 2024
This was referenced
Sep 12, 2024
This was referenced
Nov 8, 2024
This was referenced
Nov 9, 2024
This was referenced
Apr 15, 2025