allow a custom css class to be applied on anchorlinks and permalinks by ggueret · Pull Request #776 · Python-Markdown/markdown (original) (raw)

This pull request follows on #771 that I closed because it is no longer relevant.

The goal is to allow a custom css class to be applied on permalinks as suggested by @waylan in the original pull request (I unfortunately did not see your answer during my last changes).

It perfectly fulfills my need with font-awesome. Indeed, there is no need for an extra tag and it seems semantically better to apply fa- classes to a link that has a title attribute.
So I added the same keyword logic "_class" for the anchorlinks, for that matter.

I fixed the case that if the permalink is an empty string, it is treated as False and thus disabled. I guess this is the expected behavior when I look at this line, could you confirm ?

I hope this pull request can be merged as is, I remain available if changes need to be made.