Eliminate file intermediary in translate algebra by jclerman · Pull Request #2267 · RDFLib/rdflib (original) (raw)
Summary of changes
Previously, rdflib.plugins.sparql.algebra.translateAlgebra()
maintained state via a file, with a fixed filename query.txt
. With this change, use of that file is eliminated; state is now maintained in memory (so that multiple concurrent translateAlgebra()
calls, for example, should no longer interfere with each other).
The change is accomplished with no change to the client interface. Basically, the actual functionality has been moved into a class, which is instantiated and used as needed (once per call to algrebra.translateAlgebra()
). The class is available for direct use, though that's not anticipated to be useful in normal operation.
Checklist
- Checked that there aren't other open pull requests for
the same change. - Checked that all tests and type checking passes.
- For changes that have a potential impact on users of this project:
- Updated relevant documentation to avoid inaccuracies.
- Considered adding additional documentation (added PyDoc for new class)
- Considered adding an example in
./examples
for new features. - Considered updating our changelog (
CHANGELOG.md
).
- Considered granting push permissions to the PR branch,
so maintainers can fix minor issues and keep your PR up to date.