docs: recommend making an issue before making an enchancement by aucampia · Pull Request #2391 · RDFLib/rdflib (original) (raw)
Summary of changes
Suggest that contributors first make an issue to get in principle agreement for pull requests before making the pull request.
Enhanements can be controvarsial and we may reject the enhancement sometimes even if the code is good, as it may just not be deemed important enough to increase the maintenance burder of RDFLib.
Checklist
- Checked that there aren't other open pull requests for
the same change. - Added tests for any changes that have a runtime impact.
- Checked that all tests and type checking passes.
- Considered granting push permissions to the PR branch,
so maintainers can fix minor issues and keep your PR up to date.
Suggest that contributors first make an issue to get in principle agreement for pull requests before making the pull request.
Enhancements can be controversial, and we may reject the enhancement sometimes even if the code is good, as it may just not be deemed important enough to increase the maintenance burden of RDFLib.
Other changes:
- Updated the checklist in the pull request template to be more accurate to current practice.
- Improved grammar and writing in the pull request template, contribution guide and developers guide.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well worth making it clear and explicit 👍
Coverage: 90.854%. Remained the same when pulling 3f3b638 on aucampia:aucampia/20230519T1058-enhancement_guidance into e103078 on RDFLib:main.
This was referenced
Jul 6, 2023