Improve running tests locally by edmondchuc · Pull Request #1352 · RDFLib/rdflib (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Proposed Changes
- Add running tests instructions to README
- Simpler on-boarding experience for contributors who want to contribute and run tests locally with the options to run the tests on the host system or in a Docker test running environment.
- Fixes
OSError: [Errno 49] Can't assign requested addresson some OSs such as macOS. - Removes the requirement to have BerkeleyDB installed on the host system (problematic for macOS and Windows users).
…n tests in a Docker container.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good additions @edmondchuc. There has been a lot of work for the "cannot assign address" using Mock SPARQL endpoints, instead of DBPedia and in auto-allocating free local IP addresses, but I'm not sure if they are all merged yet. I don't think this container work will get in the way of that so I think this is good to go.
…ose.yml to docker-compose.tests.yml.
Good additions @edmondchuc. There has been a lot of work for the "cannot assign address" using Mock SPARQL endpoints, instead of DBPedia and in auto-allocating free local IP addresses, but I'm not sure if they are all merged yet. I don't think this container work will get in the way of that so I think this is good to go.
Please do ping me if you get any more spurious failures from tests so I can have a look, as far as I know they should be gone in master now and in forks that are up to date with master.