RFC: Add PythonInputSource to create py-based graphs by joshmoore · Pull Request #1463 · RDFLib/rdflib (original) (raw)

Not sure why this failure appeared:

Probably because between you submitting the original PR and the testing now we've changed the tests in RDFlib from nose to pytest, so something's not right there.

I'll have a look tomorrow to see if I can work it out.

BUT, I've also come up with another request for you, sorry! You say in your PythonInputSource:

"Constructs an RDFLib Parser InputSource from a Python data structure loaded from JSON with json.load or json.loads."

But the "from JSON" bit's not strictly necessary. I could load your PythonInputSource with a native Python dict, data from YAML or any other source I cared to parse into a Python object, you just happen to have used JSON. So I think the class documentation needs to be made more generic.

I could make this change but I just want to test the assumption with you first.